Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): debug option broken #117

Merged
merged 1 commit into from
Jul 16, 2020
Merged

fix(plugin): debug option broken #117

merged 1 commit into from
Jul 16, 2020

Conversation

TheAlexLichter
Copy link
Member

@TheAlexLichter TheAlexLichter commented Jul 16, 2020

When using the http.debug option at the moment, an error is thrown because the plugin is still using axios and not http as variable. This wasn't caught due to the nature of lodash templates.

image

Maybe we should add Pim's lodash template linter here as well (if possible)?

@codecov-commenter
Copy link

Codecov Report

Merging #117 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #117   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files           1        1           
  Lines          71       71           
  Branches       39       39           
=======================================
  Hits           69       69           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54e965...eedb8ee. Read the comment docs.

@pi0 pi0 merged commit 6bc1295 into dev Jul 16, 2020
@pi0 pi0 deleted the manniL-patch-1 branch July 16, 2020 17:17
@pi0 pi0 changed the title fix: debug option fix(plugin): debug option broken Jul 16, 2020
@pi0 pi0 removed their assignment Jul 16, 2020
@TheAlexLichter TheAlexLichter removed the request for review from pi0 July 18, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants