Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local version of ky-universal #111

Merged
merged 1 commit into from
Jun 12, 2020
Merged

fix: use local version of ky-universal #111

merged 1 commit into from
Jun 12, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 12, 2020

ky-universal is broken because of using specific fork of node-fetch. This PR uses a local version also ensures everything is transpiled.

@codecov-commenter
Copy link

Codecov Report

Merging #111 into dev will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #111      +/-   ##
==========================================
+ Coverage   91.07%   91.22%   +0.15%     
==========================================
  Files           1        1              
  Lines          56       57       +1     
  Branches       31       30       -1     
==========================================
+ Hits           51       52       +1     
  Misses          5        5              
Impacted Files Coverage Δ
lib/module.js 91.22% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4152f87...04f3da5. Read the comment docs.

@pi0 pi0 merged commit e7cb647 into dev Jun 12, 2020
@pi0 pi0 deleted the fix/ky-universal branch June 12, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants