Skip to content

[next] Composables usage useRouteBaseName #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BobbieGoede opened this issue Feb 16, 2023 · 0 comments · Fixed by #1869
Closed

[next] Composables usage useRouteBaseName #1862

BobbieGoede opened this issue Feb 16, 2023 · 0 comments · Fixed by #1869
Labels
🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage v8

Comments

@BobbieGoede
Copy link
Member

Environment

Reproduction

N/A

Describe the bug

The usage of useRouteBaseName differs from the other composables as it doesn't return a function to get the route base name, but directly returns the route base name. This won't work in all situations as it calls useRoute and useRouter every time, which must only be called in setup, a plugin or route middleware.

I will look into making a PR to make useRouteBaseName consistent with the other composables, please let me know if this difference in behaviour is intentional and should not be changed.

Additional context

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage v8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants