Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): add missing hid to icon tags #428

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

buoto
Copy link
Contributor

@buoto buoto commented Jan 26, 2021

The favicon head links were pushed without hid and name and they weren't deduplicated in mergeMeta:

// Avoid duplicates
if (
(item.hid && hasMeta(to[key], 'hid', item.hid)) ||
(item.name && hasMeta(to[key], 'name', item.name))
) {
continue
}

As a result they were appended every time the page was visited, causing a memory leak and crashing the server after some time.

buoto added 2 commits January 26, 2021 13:39
The favicon head links were pushed without `hid` and `name` and they weren't deduplicated in `mergeMeta`.
As a result they were appended every time the page was visited, causing a memory leak and crashing the server after some time.
@buoto buoto changed the title fix: Add links with hid fix(meta): Add links with hid Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #428 (d477c38) into master (245aadc) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files           9        9           
  Lines         367      367           
  Branches      122      122           
=======================================
  Hits          313      313           
  Misses         54       54           
Impacted Files Coverage Δ
src/meta.ts 78.78% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 245aadc...d477c38. Read the comment docs.

@atinux atinux requested a review from pi0 January 26, 2021 15:17
@pi0 pi0 changed the title fix(meta): Add links with hid fix(meta): add missing hid to icon tags Jan 26, 2021
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit d9addb7 into nuxt-community:master Jan 26, 2021
@pi0
Copy link
Member

pi0 commented Jan 26, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants