Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fix: propertyName needed to grab the full API response #232

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

f213
Copy link
Contributor

@f213 f213 commented Aug 27, 2018

Setting propertyName to undefined forces the default value because of Object.assign().

propertyName should be not undefined but falsy for Object.assign() not to rewrite it.

@farnabaz
Copy link
Member

farnabaz commented Aug 28, 2018

Thanks

I think this issue has nothing to do with Object.assign(). This is how lodash merge function works and cause this issue

@farnabaz farnabaz merged commit 315bf4b into nuxt-community:dev Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants