Import less Lodash #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for this PR. Lodash is only required inside nuxt module (Which is a part of nuxt) and modules won't be included in output bundle.So i think this won't make any difference. |
This module imports the entirety of Lodash which is very large. This results in large bundle sizes for anyone consuming this module. This PR imports only the merge function from Lodash.
|
@pi0 You're totally right, my apologies. I have an update to this (which I forgot to commit and push) that addresses the correct import which is located in auth.store.js. Please take another look. |
|
Now makes sense. Thanks for your help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module imports the entirety of Lodash which is very large. This results in large bundle sizes for anyone consuming this module.
This PR imports only the merge function from Lodash.