-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pusher driver for laravel reverb #2612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it should work, but i have to tested it
So should I wait or merge now? |
My 2 cents: I don't really feel like this is really needed... since there is essentially just a single change which is the connection name vs. the current "pusher" driver. This might be better fitted as a documentation blurb? Otherwise we might need to consider creating one for every Pusher compatible project like Reverb, Socketi, Socket Chief etc. The one thing this has going for it is that it is a official Laravel package of course. Also Reverb doesn't support web hooks so technically that route isn't needed and cleanup is not happening which is also nice if this is knows. Same issue Laravel WebSockets has. Not against this change but also not really enthusiastic about it personally. |
So we could add another method to I don't mind adding support for Reverb, as it is an official Laravel package. |
The route should be removed completely for Reverb, since it will never be called (because Reverb does not have web hooks)
Agreed! |
I made a bit of a larger overhaul in #2639, please review that. |
Resolves #2564
Changes
Allow reverb broadcast to reuse the pusher driver
Breaking changes