Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Cloud Storage #10

Open
mr-smithers-excellent opened this issue Jan 27, 2019 · 10 comments
Open

Add support for Google Cloud Storage #10

mr-smithers-excellent opened this issue Jan 27, 2019 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mr-smithers-excellent
Copy link

It would be great to include Google Cloud Storage in this offering to ensure all major cloud providers are covered by this tool.

@maorfr maorfr added enhancement New feature or request help wanted Extra attention is needed labels Jan 28, 2019
@maorfr
Copy link
Contributor

maorfr commented Jan 28, 2019

Hey @mr-smithers-excellent,

We would like to have it as well!
Would you like to get involved and add that capability?
No doubt it would be a great addition ;)

@mr-smithers-excellent
Copy link
Author

Hi @maorfr - I thought I might be volunteering for this :)

Sure, I can take it on. Do you have any contributing guidelines that need to be followed?

@maorfr
Copy link
Contributor

maorfr commented Jan 29, 2019

Thanks!

No specific guidelines, I hope the code will be a guide on its own.
pkg/skbn.go is the wrapper for all different clients.
I would expect a pkg/gcs.go to be added, and I suggest that pkg/s3.go will be the example to follow.

Looking forward for your PR ;)

@Simon3
Copy link

Simon3 commented Mar 7, 2019

Hi, any progress on this ?

@mr-smithers-excellent
Copy link
Author

I should be able to make this a priority this week.

@Simon3
Copy link

Simon3 commented Mar 12, 2019

I have actually just finished integrating it. Just need to review it quickly and I should be able to send a PR by tomorrow :)

@mr-smithers-excellent
Copy link
Author

One less thing on my list for the week then. Excited to test it out!

@Simon3
Copy link

Simon3 commented Mar 13, 2019

PR sent (#12), don't hesitate to leave a few comments if you have modification suggestions!

@benhoIIand
Copy link

@maorfr could you have a look at the PR? We'd love this feature as well.

@maorfr
Copy link
Contributor

maorfr commented Mar 26, 2019

as this repo has gone unmaintained, this feature is now a part of https://github.com/maorfr/skbn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants