Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prerequisites and Getting started doc #75

Conversation

jamie-brannan
Copy link

Aiming to close #74 and issues that may be obstacles for newbies to contributing and navigating a project using Cocoapod dependencies.

Also, perhaps a place to set what are standardised versions for packages and tools? Any thoughts?

@krugerk
Copy link

krugerk commented Jan 6, 2024

🤩 thumbs up from me

@marc-medley marc-medley self-assigned this Jan 7, 2024
@marc-medley
Copy link
Member

@jamie-brannan An intent is to keep the CONTRIBUTING.md files similar between the daily-dozen-adroid and daily-dozen-ios repositories. CONTRIBUTING.md is about overall general process and policy. The Docs/ directory is for more technical and platform specific details.

Separately, I had created a Docs/BuildNotes.md prior to this PR existing. There are some details which I'm still finalizing before checking it in. Docs/BuildNotes.md will supercede the changes in this PR and provide some needed obscure details.

As such, it is more productive to close this PR and have you test how Docs/BuildNotes.md works for you. I will let you now when Docs/BuildNotes.md is available.

There are other issues here as well that will needed to worked through. One example is that, in general, contributing PRs should come in on a develop or develop-something branch. There is more to go over. Please wait for Docs/BuildNotes.md and at that time we can go over more details.

Although closing this PR is not the expected outcome, your intiative is appreciated. Thanks.

@marc-medley marc-medley closed this Jan 8, 2024
@jamie-brannan
Copy link
Author

jamie-brannan commented Jan 8, 2024

Thanks for getting back to me however I think you're response about the build notes misses the point for my PR: this is for beginners to get up and running a build off Xcode off main or wherever.

I hear the need for identical structures between iOS and Android however this is about cocoapods installing and therefore iOS detail specific.

It's important to be explicit rather than implicit.

Is this repo is not open to beginners?

@jamie-brannan
Copy link
Author

Oh and note taken about develop: I'm a little new to working however, should the develop be associated with my own fork?

@jamie-brannan
Copy link
Author

I'd like to add the polling about develop branch to contributing and can make PRs to both Android and iOS as needed.

@nutritionfactsorg nutritionfactsorg locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started documentation section
3 participants