Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fix for updating empty CD ROM with clone image attribute #505

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Adding fix for updating empty CD ROM with clone image attribute #505

merged 8 commits into from
Oct 1, 2024

Conversation

george-ghawali
Copy link
Collaborator

No description provided.

@george-ghawali george-ghawali linked an issue Sep 26, 2024 that may be closed by this pull request
[Bug] Attaching image to existing disk in module ntnx_vms #454
Open
bhati-pradeep
bhati-pradeep requested changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@bhati-pradeep bhati-pradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add examples for this case in vms examples in examples/ folder

bhati-pradeep
bhati-pradeep previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@bhati-pradeep bhati-pradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhati-pradeep bhati-pradeep dismissed their stale review September 30, 2024 06:05

Tests are missing

bhati-pradeep
bhati-pradeep requested changes Oct 1, 2024
View reviewed changes
examples/vm_update.yml Outdated Show resolved Hide resolved
@george-ghawali
Creating seperate example file for updating empty CD ROM
5dea7c0 
Moving update empty CD ROM test to CRUD operation for IDE disks section
@george-ghawali
minor lint fix
434ed2f
bhati-pradeep
bhati-pradeep approved these changes Oct 1, 2024
View reviewed changes
examples/vm_update_cdrom.yml Outdated Show resolved Hide resolved
examples/vm_update_cdrom.yml Show resolved Hide resolved
bhati-pradeep
bhati-pradeep approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@bhati-pradeep bhati-pradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhati-pradeep bhati-pradeep merged commit 854442f into release/1.9.3 Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhati-pradeep bhati-pradeep bhati-pradeep approved these changes

Assignees
No one assigned
Labels
🐍 python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Attaching image to existing disk in module ntnx_vms
2 participants
@george-ghawali @bhati-pradeep