Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Codecov on master and production branches #3743

Merged

Conversation

itstrueitstrueitsrealitsreal
Copy link
Contributor

Context

Fixes #3708

Implementation

Adds a conditional statement in .circleci/config.yml to check if the current branch is master or production, and does not run yarn codecov --disable=gcov -f ./coverage/coverage-final.json if so. This reduces build times for both of these branches.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:58pm
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:58pm

Copy link

vercel bot commented Jul 8, 2024

@itstrueitstrueitsrealitsreal is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.87%. Comparing base (2d4743d) to head (3c32813).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3743   +/-   ##
=======================================
  Coverage   53.87%   53.87%           
=======================================
  Files         274      274           
  Lines        6032     6032           
  Branches     1449     1449           
=======================================
  Hits         3250     3250           
  Misses       2782     2782           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravern ravern requested a review from a team July 8, 2024 16:03
@ravern
Copy link
Member

ravern commented Jul 15, 2024

Thank you for your contribution! Just wanted to let you know that we haven't forgotten about your PR, will get to it hopefully this weekend :)

Copy link
Member

@zwliew zwliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! LGTM 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Codecov as a CI step on master/production branches
3 participants