-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Planner #3696
Release Planner #3696
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@wr1159 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel. @nusmodifications first needs to authorize it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3696 +/- ##
==========================================
+ Coverage 53.87% 54.75% +0.87%
==========================================
Files 274 274
Lines 6032 6043 +11
Branches 1449 1452 +3
==========================================
+ Hits 3250 3309 +59
+ Misses 2782 2734 -48 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR (including the screenshots and all)!
I think this PR looks good to me and I approve of it in-principle, but I agree with you that we should fix the mobile UI first before merging this. Thanks for pointing that out!
I'll approve this pending merge conflicts and stuff, but merging will be on hold for now due to some internal requirements with NUS. We expect to be able to merge in around a month or so 🙏 |
white-space: nowrap; | ||
margin: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove these style changes because the layout look worse on small form factors.
LGTM, thanks! |
Context
Resolves #3689
Implementation
currentTests
inBetaToggle
Other Information
Since there's no more test, the beta test toggle in settings doesn't appear by default anymore. Is this intended?
Noticed that the plan to take, exemptions and trash section overflows for mobile. Should we fix it first before releasing this to public? We can make another issue for it, because it's UI related I think we need some discussion for it.