Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for VS before 2019 #609

Closed
manfred-brands opened this issue Oct 15, 2023 · 6 comments · Fixed by #675
Closed

Drop support for VS before 2019 #609

manfred-brands opened this issue Oct 15, 2023 · 6 comments · Fixed by #675
Assignees
Milestone

Comments

@manfred-brands
Copy link
Member

We currently have separate releases 2.x and 3.x, where the first is the code without the DiagnosticSuppressors.
Those were introduced in roslyn version 3.3.1
which matches Visual Studio 2019 16.3 which is 4 years old and predates .NET Core 3.1.

I expect all users, even those addressing .NET Framework to use later SDKs to take advantage of new C# language feates.

@manfred-brands
Copy link
Member Author

@mikkelbu If you agree, could you take this on please?

@mikkelbu
Copy link
Member

I agree that we should stop the 2.x releases. Looking at https://www.nuget.org/packages/NUnit.Analyzers the 2.x download numbers are a tiny fraction of the 3.x. I'm very busy at the moment, but I think I've time for this (it should be a small task).

@mikkelbu mikkelbu self-assigned this Oct 15, 2023
@mikkelbu mikkelbu added this to the Release 4.0 milestone Oct 27, 2023
@manfred-brands
Copy link
Member Author

Depends on #638 which adds more #if NETSTANDARD code.

@manfred-brands
Copy link
Member Author

At the same time I wanted to move to .NET8.0 SDK to match NUnit.
However, the corresponding updated Roslyn Analyzer now insists on separating the CodeFix from the Analyzers.
CodeFixes should only be loaded by IDE, not by the build process.

@manfred-brands
Copy link
Member Author

manfred-brands commented Nov 19, 2023

In addition to that, unit tests fail due some other changes they made: GuOrg/Gu.Roslyn.Asserts#320

@mikkelbu
Copy link
Member

mikkelbu commented Jan 20, 2024

@manfred-brands I think I'll make an attempt on dropping support for VS 2017 (and lower) for the release this weekend, and then make the release version 4, and then we can push .NET8.0 SDK and bumping Roslyn Analyzers to a future fix - i.e. splitting this issue into two issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants