Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zprint: change args ordering #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zprint: change args ordering #308

wants to merge 1 commit into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 2, 2025

Fixes #307

@zimbatm zimbatm mentioned this pull request Feb 2, 2025
Open
sg-qwt
sg-qwt suggested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@sg-qwt sg-qwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not mkAfter but mkBefore, since mkBefore is used by default in mkFormatterModule, need something stronger than mkBefore here, for example
lib.mkOrder 100 (lib.optional (cfg.zprintOpts != null) cfg.zprintOpts);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg-qwt sg-qwt sg-qwt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mkFormatterModule zprint argument misplacement
2 participants
@zimbatm @sg-qwt