Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce notification theme broken #743

Open
fish47 opened this issue Apr 16, 2020 · 6 comments
Open

xfce notification theme broken #743

fish47 opened this issue Apr 16, 2020 · 6 comments

Comments

@fish47
Copy link

fish47 commented Apr 16, 2020

before
before

after
after

source
https://bbs.archlinux.org/viewtopic.php?id=254478

@fish47
Copy link
Author

fish47 commented Apr 16, 2020

should we specify a standalone gtk.css for xfce?
#677

@khurshid-alam
Copy link
Contributor

Please specify version for xfce or numix, 8083a96 should have fixed this.

@Flowneee
Copy link

Please specify version for xfce or numix, 8083a96 should have fixed this.

Hi, I'm the original author of thread on arcglinux.org. Currently my version of numix is local/numix-gtk-theme-git 2.6.7.r51.b652b19-1, so (I assume) it refer to commit b652b19, which is latest in current master. About xfce version: 4.14 (everything is latest from arch repo). The only exception is xfce4-notifyd: 0.4.4, because latest is not working correctly with numix.

@ochosi
Copy link
Contributor

ochosi commented May 26, 2020

Notifyd was updated with respect to its base/fallback class so your code doesn't apply anymore.
The "osd" class was dropped so you need to at least drop the lines referring to it:


This will likely improve things but you may also have to specify a few more things like colors. The new fallback class is "keycap" (because this looks best out of the box with Adwaita).

@darkshram
Copy link
Contributor

Commit 8083a96 only works for xfce4-notifyd 0.4. My suggestion to have this issue fixed is to discard the current code for xfce4-notifyd, and do the same as Greybird gtk theme and create a Numix specific stylesheet file for xfce4-notifyd based on the Greybird stylesheet for xfce4-notifyd and just adapt it with the Numix color palette and style. Currently, Numix includes a gtkrc file for gtk2 based xfce4-notifyd, and there is no gtk.css file for the gtk3 based one.

Something like this (replacing $osd_bg with #444 and $osd_fg with #eee?) for xfce4-notifyd-0.4/gtk.css:

#XfceNotifyWindow {
    background-color: shade($osd_bg, 0.3);
    color: $osd_fg;
    border: 1px solid shade($osd_bg, 0.6);
    border-radius: 6px;
}

#XfceNotifyWindow button {
    background-image: none;
    background-color: shade($osd_bg, 0.3);
    color: $osd_fg;
    border-color: shade($osd_fg, 0.35);
    border-radius: 3px;
}

#XfceNotifyWindow button:hover {
    background-color: shade($osd_bg, 0.4);
    border-color: shade($osd_fg, 0.45);
}

#XfceNotifyWindow label#summary {
    font-weight: bold;
}

#XfceNotifyWindow progressbar {
    min-height: 6px;
    border-radius: 3px;
}

#XfceNotifyWindow progressbar progress {
    background-image: none;
    background-color: $osd_fg;
    border: none;
    box-shadow: none;
}

#XfceNotifyWindow progressbar trough {
    background-image: linear-gradient(to bottom,
                                      shade($osd_bg, 0.65),
                                      shade($osd_bg, 1.25)
                                      );
    border: 1px solid shade($osd_bg, 0.2);
    border-radius: 3px;
    padding: 1px 0;
}

@c1ph3rl1nux
Copy link

c1ph3rl1nux commented May 24, 2021

@darkshram
Your suggestion works for me. See screenshots..
Screenshot_2
Screenshot_1

PS: if you have some time maybe you could take a look at this #752? All day I've been trying to figure out why Lightdm is ignoring Numix's login window background color. Any help or input would be welcome, cheers in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants