[Issue] duplicated email to user

[sync-by-unito]

User story

As a user, I want to receive only one email instead of receiving two duplicate emails, so that I don't get annoyed by receiving the same information twice.

Reproduce step

1. choose an asset & operate "mint & share" network action
2. when network action processing complete, user will receive an email
3. But user will get two emails

Expectation

1. User should receive one email instead of two duplicate email.

Additional information:

The email seems one is from backend, another one is from bubble.

This issue only happened on English user

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

[sync-by-unito]

➤ Kenny Hung commented:

Natalie Wang The email issue is here.

[sync-by-unito]

➤ Natalie Wang commented:

Kenny Hung 提醒一下，今天跟Featured creator- Koen 聊時，他有跟我提2封email的事喔，麻煩記得安排進sprint 修改，感恩

[sync-by-unito]

➤ Kenny Hung commented:

Olga (cc Scott Yan)

想跟你確認下，目前Capture App 英文使用者，在mint & share後會收到兩封信，如task附件，我看了一下內容，有一個還是連到之前舊的CaptureClub的信，這封信應該也是由Backend這邊寄送出去的才對？（我是對照了這個 sheet ( https://docs.google.com/document/d/1y_qNQ0oqAEl5ntj0C_UEtaDrBg9pp_bda9HuE9LgNWU/edit ) 的資訊）

如果是Backend的話，不知道有沒有辦法一起在這個sprint修？

[sync-by-unito]

➤ Olga commented:

Kenny Hung 第一個附件是 storage backend 寄的，第二個應該不是耶。

從程式碼看到的標題和寄件人是第一個附件。

[sync-by-unito]

➤ Olga commented:

兩個方式修正，傾向第一個，看你的想法

1. bubble 移除通知，storage backend 保持不變
2. bubble 修改連結，storage backend 移除通知

[sync-by-unito]

➤ Kenny Hung commented:

Olga Thanks for the confirmation. I agree with your suggestion.

Ethan Wu Need your help to check this email "A new Capture NFT has been minted and shared on the Capture Explore page!" is triggered by bubble?

If yes, please help to fix it. Because current user has already received email from backend, we don't need to send this mail.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung is this from network action?

[sync-by-unito]

➤ Ethan Wu commented:

also i can confirm that an email is sent from bubble backend workflow. it happens from the list_product step

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu I'm not really sure, but I could reproduce when Capture App user is set English & mint & share completely, they will receive two emails.

1. First one is from backend. (Capture NFT..., see first attachment.)
2. Second one is duplicated & the link is wrong. (Link to CC, the title is "A new Capture...".)
   1. Not sure where it's sent from.

We don't have to fix it this sprint, but we could figure out this email is sent from?

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung i can confirm that this email is sent from bubble. if storage backend is already sending an email i can simply remove this "send email" step from the bubble backend workflow

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu Thanks & confirm

1. Which product is this task?
2. Could we add this one into this sprint?

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung yes you can add into this sprint.

this should be network action since its tied to mint & share

[sync-by-unito]

➤ Ethan Wu commented:

miro for fix: https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764558775885041&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764558775885041&cot=14 )

https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764558775885041&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764558775885041&cot=14 )

[sync-by-unito]

➤ Ethan Wu commented:

since captureclub project plan allows just one branch, we will need previous network action release to pass qa and be deployed before implementation. in the mean time I have attached the miro diagram for this fix. see above comment for more details.

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu (cc Sofia Yan)

I found this issue still existed on live version, when you have time, could you help to confirm this part?

[sync-by-unito]

➤ Ethan Wu commented:

i know what the issue is. there are multiple list_product workflows. i disabled the send email in the wrong one. will make the change in verstion-test branch of captureclub and resubmit

[sync-by-unito]

➤ Kenny Hung commented:

Just confirm, so the last modified doesn't applied on the live version?

[sync-by-unito]

➤ Ethan Wu commented:

it did but like i said in the bubble backend workflow side there are multiple list_product workflows

• list_product
• list_product (asset_origin)
• list_product (asset_clone)

the change i made was to list_product however after I took a look a the workflow the mint capture workflow uses list_product (asset_origin)

so to summarize, i modified the wrong one

[sync-by-unito]

➤ Kenny Hung commented:

Okay, I think it could be arranged into next sprint.