Fix excessive api call #3157
Merged
Fix excessive api call #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storeIndexedProof is called from storeRemoteCapture. storeRemoteCapture most of the time is called when user restore (during app start) or reload (triggers pull to refresh)
shc261392
reviewed
Dec 26, 2023
| @@ -72,8 +72,7 @@ export class CaptureItemComponent { | |||
| ); | |||
|
|
|||
| readonly hasCaption$ = this.proof$.pipe( | |||
| switchMap(proof => this.diaBackendAssetRepository.fetchByProof$(proof)), | |||
| map(asset => asset.caption !== '') | |||
| map(proof => proof.caption.trim() !== '') | |||
There was a problem hiding this comment.
Is there any reason why trim() is added?
There was a problem hiding this comment.
@shc261392, just for safety. But I believe backend handles empty strings therefore I removed trim() in this commit refactor(capture-item): remove unnecessary .trim() on caption
sultanmyrza
changed the base branch from
v231207-capture-cam-ionic
to
v240104-capture-cam-ionic-launch
shc261392
approved these changes
Jan 11, 2024
sultanmyrza
merged commit d9b5652
into
v240104-capture-cam-ionic-launch
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3137. Here is the demo
┆Issue is synchronized with this Asana task by Unito