Feature/go pro/bug fix/refetch photos #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capcitory wifi plugin
…ctly from camera)
enable `Automatically manage signing`
sultanmyrza
commented
Dec 27, 2021
| @@ -358,7 +358,7 @@ | |||
| CODE_SIGN_ENTITLEMENTS = App/App.entitlements; | |||
| CODE_SIGN_IDENTITY = "Apple Development"; | |||
| CODE_SIGN_STYLE = Automatic; | |||
| CURRENT_PROJECT_VERSION = 1; | |||
| CURRENT_PROJECT_VERSION = 2; | |||
There was a problem hiding this comment.
I just updated build number for "Capture Exp App" to be able to upload to TestFlight
sultanmyrza
commented
Dec 27, 2021
| @@ -250,7 +250,7 @@ export class GoProMediaService { | |||
|
|
|||
| const data = response.data; | |||
|
|
|||
| const files = data.media[0].fs as any[]; | |||
| const files = (data.media[0].fs as any[]).reverse(); | |||
There was a problem hiding this comment.
I noticed that files were showing oldest first.
I could also read GoPro docs to get asc by timestamp. But I think just reverse array is quicker solution
…pro and upgrade versionCode
shc261392
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added refresh button to refetch photos from GoPro here is the video
It's last commit in this pull request, or here is the exact url to commit
FinalVideo_1640587801.182154.MOV
┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang