Feature/go pro/phase 2/part 3/pull request #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capcitory wifi plugin
…ctly from camera)
enable `Automatically manage signing`
Closed
shc261392
reviewed
Nov 11, 2021
Comment on lines
5
to
6
| <domain includeSubdomains="true">10.5.5.9</domain> | ||
| <domain includeSubdomains="true">192.168.8.155</domain> |
There was a problem hiding this comment.
10.5.5.9 seems to be the default IP address of GoPro, but what is 192.168.8.155?
There was a problem hiding this comment.
removed in this commit 👍
shc261392
requested changes
Nov 12, 2021
|
|
||
| ngOnInit() { | ||
| this.restoreBluetoothConnection(); | ||
| // this.scanForBluetoothDevices(); |
Comment on lines
85
to
102
| // if (newtorkStatus.connectionType == 'wifi') { | ||
| // const connectedToGoProWiFi = | ||
| // await this.goProWiFiService.isConnectedToGoProWifi(); | ||
|
|
||
| // if (!connectedToGoProWiFi) { | ||
| // this.startUploadToCapture(); | ||
| // return; | ||
| // } | ||
| // } | ||
|
|
||
| // if (newtorkStatus.connectionType == 'cellular') { | ||
| // const allowed = await this.allowUploadWithMobileInternet(); | ||
| // if (allowed) { | ||
| // this.startUploadToCapture(); | ||
| // return; | ||
| // } | ||
| // } | ||
| } |
Comment on lines
201
to
206
| // this.presentToast(`Wifi.connectPrefix`); | ||
| // console.log(`Connecting to ${wifiSSID} with password ${wifiPASS}`); | ||
| // await Wifi.connectPrefix({ | ||
| // ssid: wifiSSID, | ||
| // password: wifiPASS, | ||
| // }) |
shc261392
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang