-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to input custom creator #3147
Comments
➤ Tammy Yang commented: Sherry ChungKenny HungEthan Wu please make sure the milestone card of dashboard release on 26th Dec is opened. I can't find it yet. Once created, please put this as the dependency to it. |
➤ Ethan Wu commented: the milestone card is here: v231218-capture-dashboard ( https://app.asana.com/0/1201016280880500/1206201661307151/f ) |
➤ Olga commented: When users type the creator name, we can set the assetCreator in a custom field, for example: nit_commit_custom: {"assetCreator": "test"}, and it will override the assetCreator in the asset tree. However, when users claim they're the creator, please refrain from having the assetCreator key in the nit_commit_custom field to prevent it from overriding the creator name., for example: nit_commit_custom: {}, and the backend will set it in the commit automatically. |
➤ Sherry Chung commented: Tammy Yang Please check above message from Olga. I would suggest we first keep the single upload as it is now and deploy the new method in multi-upload for update customer creator. After confirm there is no further issue, we then go back to fix single upload for update customer creator. |
➤ Ethan Wu commented: I noticed that there has been a change made to the LIVE branch to include assetCreator in the nit_commit_custom. I think this implementation isn't so straight forward because we don't want to override the creator in situations where the toggle for claim creator is on. |
➤ Tammy Yang commented: It won't overwrite. |
[User story #1]
As a user, I want to be able to input the name of the creator if the "claim copyright" toggle is off so that I can help others to register the creations with the correct names of assetCrestor.
[User story #2]
As a user, I want the initial value of the custom creator field can be the same as the assetCreator field found by the parsing API so that I don't need to fill the name manually.
[Current status]
Claap: https://app.claap.io/numbers-protocol/custom-creator-to-ethan-and-qa-c-O35CsUM4Uy-UZLHtETpLeh3
┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang
The text was updated successfully, but these errors were encountered: