-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v231214-dashboard-support headline #3130
Comments
➤ Kenny Hung commented: Ethan Wu (cc Sherry ChungTammy Yang) Considering that in this sprint you also need to implement staking site, about dashboard part, please deal with headline first, if other dashboard tasks need adjustment, please let us know. |
➤ Tammy Yang commented: Kenny Hung just wondering, I thought we have already supported this? I saw it in the latest release already. |
➤ Kenny Hung commented: Tammy Yang Dashboard headline support not only confirm page but also editing the Page(user could edit headline after asset registration. |
➤ Tammy Yang commented: Wait, but if user edit after the registration, user needs to pay extra fee, right? I think this also needs to be considered. Better to implement together. |
➤ Sherry Chung commented: Ya, great point. I'll consume NUM (credits). Better to do it together. We can discuss later when Ethan is on this tasks |
➤ Kenny Hung commented: Yes, I've summarized the miro ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764569132974689&cot=14 ) flow. Maybe we need to add a reminder to let users know these actions(edit headline & caption) need to pay a few fee for the record on-chain. |
➤ Ethan Wu commented: we should allow users to edit headline and captions post registration. currently when users edit captions we are just editing it with storage backend - edit media api call. not sure when this action is called if a new commit is automatically created. if not than we will still need to edit the workflow add a commit to have the caption changed. if users have to pay than we can add a reminder telling users that it will cost funds to make the edits. |
➤ Kenny Hung commented: Current status: User edit captions will also create a new commit. |
➤ Ethan Wu commented: ok than we will just need to have some UI to inform users that it will cost them some funds to make the edits |
➤ Kenny Hung commented: Ethan Wu
|
➤ Ethan Wu commented: Does this only happen with all files in multiupload? |
➤ Kenny Hung commented: Ethan Wu You mean #1? If yes, yes only happened on multiple upload. |
➤ Kenny Hung commented: Ethan WuTammy Yang v231214 still have some issue, please fix them. #2, 3 Fixed #1 Fixed, but QA found the verified will change to fail. curl --location 'https://dia-backend.numbersprotocol.io/api/v3/assets/bafybeigf6njeutqqht7lnrdoscmqenv3fvs6a3uupobcns7gtajo7snvfa/verify-signature/?address=0x82bc4A604BABE7014F41323Fc2866550e24D9F58 ( https://dia-backend.numbersprotocol.io/api/v3/assets/bafybeigf6njeutqqht7lnrdoscmqenv3fvs6a3uupobcns7gtajo7snvfa/verify-signature/?address=0x82bc4A604BABE7014F41323Fc2866550e24D9F58 )' \ --header 'Accept: application/json' \ --header 'Authorization: token {auth_token}' API response { "error": { "type": "signature_verification_failed", "message": "The address recovered from the signature and message is different with the provided address.", "details": { "provided_address": "0x82bc4A604BABE7014F41323Fc2866550e24D9F58" } }, "status_code": 400 } #4 Still the same, I've created a sub-task for it. If the headline or caption is modified and then cancelled, clicking ‘edit’ immediately again shows the uncorrected information. A reload is needed to display the original values. ( https://app.asana.com/0/0/1206218031114721/f )
|
➤ Kenny Hung commented: Ethan Wu Please fixed #1, current way could be let user can’t clean the caption, please refer Comment by @tammy Yang on When user change caption / headline to empty, then press confirm, actually nothing happened. ( https://app.asana.com/0/0/1206218374042983/1206142917957871/f ) If caption / headline has value doesn't let user clean it. |
➤ Ethan Wu commented: Kenny Hung you mean fix it so that the fields cannot be empty? |
➤ Kenny Hung commented: Yes |
﹍Product code:﹍
﹍Release milestone:﹍
﹍Testing level:﹍
C
﹍Release note:﹍
﹍Expectation:﹍
﹍Known Issue:﹍
﹍Known issues collection (Dashboard)﹍
﹍Limitation:﹍
﹍Test Link﹍:
https://dashboard.captureapp.xyz/version-9k1r/
﹍Note:﹍
﹍Testing Results (add this after QA test)﹍:
﹍Testing Plan (add this after QA test):﹍
https://docs.google.com/spreadsheets/d/1ppzwv4Xf1Xm97r5abX5Egim_WAahvE7n853dibzGC9Q/edit#gid=579355519
Testing Levels:
┆Issue is synchronized with this Asana Milestone by Unito
┆Created By: Kenny Hung
The text was updated successfully, but these errors were encountered: