Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] The paste button on SEND page should work #2883

Open
sync-by-unito bot opened this issue Jul 4, 2023 · 16 comments
Open

[issue] The paste button on SEND page should work #2883

sync-by-unito bot opened this issue Jul 4, 2023 · 16 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 4, 2023

User story

As a user, I want to paste address for one click so that I can conveniently and quickly paste address without the need for manual typing or more actions.

Reproduce step

  1. Go to SEND page on wallet page
  2. copy the address in advance, and press the paste icon
  3. it can't work on

Expectation

The paste button on SEND page should work normally.

Additional information:

It from https://dt42-numbers.slack.com/archives/C0323488MEJ/p1688023864714519 (1-b)

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 4, 2023

➤ Kenny Hung commented:

This task will be arranged into next sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 5, 2023

➤ Ethan Wu commented:

Sam let me know what needs to be done to start implementing this one.

i can share with you my current implementation if it helps:

I have a TextField which I assigned the ID: paste

Run JavaScript:

const paste = document.getElementById('paste');

navigator.clipboard.readText().then((clipText) => (paste.value = clipText));

ideally for this one we should be able to paste even things that have appeared outside of Capture App

let me know if you need anything else

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Ethan Wu commented:

Sam can you let me know what the progress is on this one. depending on the progress we may need to update kenny on the progress and delay to another sprint

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Sam commented:

Ethan Wu this task was not part of Sprint 23.07.03 ( https://app.asana.com/0/1204752429376440/1204752429376440 ) so I didnt look at it. I can work on it in upcoming sprint (after 07.23).

Regarding Comment by @Ethan Wu on [issue] The paste button on SEND page should work ( https://app.asana.com/0/1204924712396549/1204924712396549/1204951989270743 ) looks good to me but we still need to experiment and try how it works. We might adjust it during experiment (trying in capture-app)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Ethan Wu commented:

Kenny Hung See above comment. Pls move this task to 7.23 sprint

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Kenny Hung commented:

I push to next sprint. (0717)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Sam commented:

Kenny Hung this task should also has ionic part in next sprint

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 13, 2023

➤ Sam commented:

Ethan Wu, which bubble branch I can test it?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 13, 2023

➤ Ethan Wu commented:

Sam the paste button is currently hidden in both branches and as mentioned in other comments the current branches are either just passing qa or undergoing code review and as such they cannot be modified. it might be better if maybe you create a sample project with a text field and paste button and try like that.

if you need help setting up the sample project i can do that for you.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 13, 2023

➤ Sam commented:

Ethan Wu, understood, I think it's okay I can quickly create simple project myself and will share my result with you soon. Thank you for clarification 🙏

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 19, 2023

➤ Sam commented:

Ethan Wu, I finish experimenting and have idea on how we can achieve that. Most challenging part was how to add remove listeners but then luckily I found that addListener have parameter called once ( https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#parameters ).

Here is the claap explaining how we can accomplish paste button

https://app.claap.io/numbers-protocol/proof-of-concep-past-button-iframe-ionic-c-O35CsUM4Uy-zdnIkDrUNM_2 ( https://app.claap.io/numbers-protocol/proof-of-concep-past-button-iframe-ionic-c-O35CsUM4Uy-zdnIkDrUNM_2 )

Here is the sample bubble page ( https://bubble.io/page?type=page&name=experiment_paste&version=87gw&id=captureappiframe&tab=tabs-1 ) with JavaScript included.

Please let me know if any questions.

Kenny Hung I suggest [issue] The paste button on SEND page should work ( https://app.asana.com/0/1201016280880500/1204924712396549/f ) to split into 2 tasks

  1. The paste button on SEND should work (ionic side) (assigned to Sam)
  2. The paste button on SEND should work (bubble side) (assigned to Ethan Wu)

Add 1, 2 into relevant milestones and make sure they release at same time (or close to each other)

Just in case #1 is done and can be added to next earliest milestone.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 26, 2023

➤ Kenny Hung commented:

#2 maybe add into next sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 28, 2023

➤ Kenny Hung commented:

Sam How QA to check this one?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 7, 2023

➤ Sam commented:

Kenny Hung, this task is not blocking v230725-capture-app-ionic-internal ( https://app.asana.com/0/1201016280880500/1205066099827825 ) right?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 8, 2023

➤ Kenny Hung commented:

Sam Yes, it doesn't block, just want to confirm how to verify it, I mean ionic side, bc iframe side hasn't implemented.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 8, 2023

➤ Sam commented:

Kenny Hung I tested ionic side on my local machine. But QA can not test ionic side until iframe side is implemented.

When iframe side is implemented I can include ionic side to ionic release. Then QA can test as a normal user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants