Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on "[issue] the Account (Wallet) page looks the same as the one on Capture App + have same functionality as wallet iframe" #2874

Closed
sync-by-unito bot opened this issue Jun 30, 2023 · 17 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jun 30, 2023

Spilt from ✓ [issue] the Account (Wallet) page looks the same as the one on Capture App + have same functionality as wallet iframe

  1. Suggest the "i" explanatory section should be added to the Wallet page.

These items pause implement.

  1. The functional area should be also a colored background. This includes the section in the Send Page that calculates the total amount. (

  2. Since the browser already has a back button, it may look odd to have an additional back button on this page. However, I'm not certain if this back button can be made to function the same way as the browser's original back button.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 2, 2023

➤ Tammy Yang commented:

Also move this to sprint 23.07.17

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 6, 2023

➤ Ethan Wu commented:

Kenny Hung for #2 do we want to go with the pink gradient background? i felt like this one was a bit out of place given the color arrangement of dashboard

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 6, 2023

➤ Kenny Hung commented:

Ethan Wu (cc Tammy Yang)

humm...this task is the next sprint task, maybe we could ask noir about this part?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 6, 2023

➤ Ethan Wu commented:

Kenny Hung i can implement this for this sprint and if we decide not to keep it i can easily remove later

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 20, 2023

➤ Ethan Wu commented:

Kenny Hung there is a redesign for dashboard in progress. since it doesn't affect the functionality of the wallet page i will hold off on implementing the gradient background.

i will focus on adding the "!" to the wallet page

@sync-by-unito sync-by-unito bot closed this as completed Aug 21, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 21, 2023

➤ Kenny Hung commented:

Tammy YangEthan Wu

Currently, the SEND NUM to another address has been deployed on Capture Cam, do we also consistent this feature on dashboard in this release?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 21, 2023

➤ Ethan Wu commented:

Kenny Hung pending approval from tammy i can add this in.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 21, 2023

➤ Tammy Yang commented:

Kenny HungEthan Wu there is no need to update at the moment as the whole wallet and send features may be completely removed from dashboard (as dashboard targets to provide SaaS)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

Ethan Wu

There are two parts need to fix.

  1. The layout is weird.

image.png

  1. The text on Deposit page

image.png

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

Kenny Hung which browser are you using

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

Ethan Wu

I try edge, safari & mobile view, all of them will happen this issue.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

Kenny Hung fixed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

Ethan Wu I found there is still the layout issue on iOS.

IMG_7C74A444DED3-1.jpeg

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

can you give me the account details. Kenny Hung i think when the account balance has a certain number of digits it has overflow.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

DM'ed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

qa pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants