Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload the same photo twice from dashboard and the Nid is different #2859

Closed
sync-by-unito bot opened this issue Jun 27, 2023 · 9 comments
Closed

Upload the same photo twice from dashboard and the Nid is different #2859

sync-by-unito bot opened this issue Jun 27, 2023 · 9 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jun 27, 2023

Upload #1: https://nftsearch.site/asset-profile?nid=bafkreiah626ihlbree44xbww74xo4zh6r2dxxzv52tmjzowzk7oyp5ydja

Upload #2: https://nftsearch.site/asset-profile?nid=bafkreiconcps23htjaeiy3xwbmvystmtq5fthjnzzu74e6ppygpsion37m

Critical issue #1: No pre-existing found (this was probably because bafkreiah626ihlbree44xbww74xo4zh6r2dxxzv52tmjzowzk7oyp5ydja was deleted at the time Upload #2 happens. However, still a critical issue that we need to think about.

Critical issue #2: The Nid should remain the same if users always use dashboard to upload. Need to check if Bubble compress the file.

Steps to reproduce:

  1. Open dashboard
  2. Upload a photo
  3. Delete the photo from backend using API
  4. Upload the photo again

Repeat #3 and #4, around 50% opportunity the Nid changes.

Expectation

When user upload creation to

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Kenny Hung commented:

Tammy YangEthan Wu (cc Scott Yan)

Verified this issue.

I upload the same image

First one: https://nftsearch.site/asset-profile?nid=bafkreif742jkad2ybwuawzvcub23wmzjg73hk6i2snyn6ewf3lkrnmxvju ( https://nftsearch.site/asset-profile?nid=bafkreif742jkad2ybwuawzvcub23wmzjg73hk6i2snyn6ewf3lkrnmxvju )

Second one: https://nftsearch.site/asset-profile?nid=bafkreigbhcb2lj3hlcgdf2ioybiicrzthy3dxlbp2c6xunrcx6rhhpdbni ( https://nftsearch.site/asset-profile?nid=bafkreigbhcb2lj3hlcgdf2ioybiicrzthy3dxlbp2c6xunrcx6rhhpdbni ) (It shows pre-existing icon)

I also download the file from backend, found the 1st image is smaller than the origin, but 2nd is the same.

I guess dashboard may compress the image/video.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Tammy Yang commented:

Kenny Hung great discovery. Please assign the issue to Ethan Wu. We may need to look for supports from Bubble, but this is something that we need to fix asap.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Kenny Hung commented:

Tammy YangEthan Wu

I suggest this item arranged into 0703 sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Ethan Wu commented:

Kenny Hung can you provide me with the file. i will draft a bubble support ticket now

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Kenny Hung commented:

Ethan Wu

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Ethan Wu commented:

support ticket sent. waiting for feedback.

my initial thoughts are we might need to leverage a different FileUploader component in bubble (one that doesn't compress files).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Tammy Yang commented:

Or create one frontend widget, with ChatGPT this may not be too difficult.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 2, 2023

➤ Tammy Yang commented:

This is critical, but as there are something we need to clarify with Bubble, I have moved it to the sprint 23.07.17

Ethan Wu please use Sprint 23.07.03 ( https://app.asana.com/0/1204752429376440/overview ) to communicate with Bubble and keep updating the task.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 5, 2023

➤ Ethan Wu commented:

so i did some searching around and it seems like bubble does do an automatic compression which we can try to bypass by adding some imgx parameters following the file url.

@sync-by-unito sync-by-unito bot closed this as completed Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant