-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue] back button will back to wrong page (should in the explore tab not my capture tab) #2480
Comments
➤ Ethan Wu commented: Kenny Hung i think this one needs some help with Sam |
➤ Sam commented: Kenny Hung, it's more like ionic task I will take this task. |
➤ Sam commented: I'm not sure if bubble iframe is affecting ionic route. Need more time for research. When back button is pressed bubble navigates back and maybe also effecting window.history of ionic app 🤔 |
➤ Sam commented: Kenny Hung, it also happens for settings page 😅 |
➤ Sam commented: I conducted small testing:
Summary: Potential solution find a way to isolate iframe navigation from ionic navigation (WIP). |
➤ Sam commented: Relevant Stack overflow suggestion How to prevent IFRAME from redirecting top-level window ( https://stackoverflow.com/a/21347627/6133329 ). |
➤ Sam commented: I tried to understand better and try all screens (probably we can rename it [issue] iframe + ionic navigation) This issue happens when user
Here is the demo |
➤ Sam commented: Kenny Hung, (cc: Tammy Yang) Also in wallets page if I open Buy Num page and go back it will stuck in loop so I need to fix that as well. |
➤ Kenny Hung commented: This task should be more important than [issue] Error message when without device permission ( https://app.asana.com/0/1201016280880500/1203710087434660/f ). |
➤ Sam commented: Developer note ( https://ireadyoulearn.info/2022/02/27/advanced-navigation-of-single-page-applications-inside-an-iframe/ ): https://app.asana.com/app/asana/-/get_asset?asset_id=1204142108316917 ( https://app.asana.com/app/asana/-/get_asset?asset_id=1204142108316917 ) Todo: check how back navigation works in bubble apps. |
➤ Sam commented: Developer note: ( https://medium.com/analytics-vidhya/angular-routing-imperative-vs-popstate-7d254b495c54 ) Summary: Angular apps have 2 types of navigation. Imperative navigation & Popstate navigation.
So I assume bubble navigate back uses window.history.back()thus causing back button issue. capture ionic uses Imperative navigation One solution that might work is to use Popstate navigation in capture ionic. |
➤ Sam commented: Developer note: ( https://ionicframework.com/docs/angular/navigation#non-linear-routing ) |
➤ Sam commented: Seems like it worked 🤞. Will do proper testing tomorrow morning if everything works will mark as completed. |
➤ Sherry Chung commented: Kenny Hung [user test feedback]. In general, this issue is fixed and there are no other questions. However, I found that the layout of asset page (entering from My Capture) and product page (entering from Explore) is different. On asset page, there's no lower banner of the "3 tabs" icon. (see below image) If we choose to fix the page layout and make the 2 layouts the same (eg. remove the lower banner with 3 tabs on the product page. And this also matches Figma). Maybe we won't need to spend time fixing the back button issue described in this task. [Remind] When encountering issues, removing features that cause this issue is also a solution. |
Your email:
[email protected]
Is this a general issue/FR report or a ticket that involve your personal account?:
No personal information involved
Select product:
Capture App
One line to describe the issue you see or the feature you want to add:
[issue] back button will back to wrong page
Let us know what do you expect to see?:
When user in the prod page, and then press the back button, it should back to right page.
Please provide some simple steps to help us reproduce the issue or understand how do you want to see the feature.:
Will see the asset page instead of explore page.
What's the device or browser do you use?:
All device will happened this
User story
As a Capture App User,
I want to the back button in the upper left corner of my screen could lead the right page
so that I can return to the previous page.
———————————————
This task was submitted through Issue Report/Feature Request
https://form.asana.com/?k=OlNjzNIasZt0uOT5gzb7pw&d=1200886955782960
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: