-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Add edit feature for user description & background img on profile page #2435
Comments
➤ Sam commented: Kenny Hung, can you please provide more information, screenshots or reference to figma or ppt please 😅 |
➤ Kenny Hung commented: SamTammy Yang Because I found we don't confirm when "edit profile page" added where the "activities" & "inbox" should be.
About profile background could add when we confirm to add edit profile page in this page. |
➤ Sam commented: Kenny Hung, sure. Let's wait what's Tammy Yang, think about that. Also would be nice to give some raw drawings so I can better imagine what is expected. Describing UI with text is bit difficult to image. |
➤ Kenny Hung commented: Sam Thanks for remind. This is my proposal. (Need Tammy Yang's confirmation.) |
➤ Tammy Yang commented: Our rule: No Figma design can remove the existing feature. Any task with the purpose of “fit Figma” should not touch the removal of the feature. Therefore, please KEEP activities and inbox at the original place (don't move it) In this case, Kenny Hung 's suggestion to allow users press and edit the description is good. We should have an edit icon to notify users that this is editable. Same for the background. No need for follow/following yet. To summarize:
Because there is no such fields of user profile in the backend, I suggest reschedule the task. Kenny Hung you can check dbdiagram next time so that you will know in order to complete this task, we need to open the task for backend first. |
➤ Tammy Yang commented: Screenshot of the User table from dbdiagram ( https://dbdiagram.io/d/604602f2fcdcb6230b2311fe ) |
➤ Kenny Hung commented: Tammy Yang (cc Sam ) Thanks for clarify. |
➤ Tammy Yang commented: Kenny Hung for the background, refer to Facebook. When viewer is the owner of that profile, show an edit icon. |
➤ Tammy Yang commented: I think FB shows the convention of these features. Just follow the UI of it. |
➤ Kenny Hung commented: Sam (cc Tammy Yang) |
➤ Tammy Yang commented: Agreed! |
➤ Sherry Chung commented: Kenny Hung (cc Tammy Yang ) please mapping this to exiting Roadmap |
Spilt from ✓ Fit figma - Edit profile page
Expectation
On future sprint we should continue adding
On sprint 1219 we finished
User story
As a capture app user, I want an edit profile page, so that I can edit my information easily.
┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung
The text was updated successfully, but these errors were encountered: