Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add edit feature for user description & background img on profile page #2435

Open
sync-by-unito bot opened this issue Dec 28, 2022 · 12 comments
Open

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 28, 2022

Spilt from ✓ Fit figma - Edit profile page

Expectation
On future sprint we should continue adding

  1. Press description to edit profile description (needs to limit characters, need to confirm with backend)
  2. Press description to upload background (need to confirm with backend)
  3. Have an edit icon to notify users that this is editable. (User name, description, upload background)

On sprint 1219 we finished

  1. Click profile => can update profile
  2. Click user name => can update user name

User story
As a capture app user, I want an edit profile page, so that I can edit my information easily.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 4, 2023

➤ Sam commented:

Kenny Hung, can you please provide more information, screenshots or reference to figma or ppt please 😅

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 5, 2023

➤ Kenny Hung commented:

SamTammy Yang Because I found we don't confirm when "edit profile page" added where the "activities" & "inbox" should be.
Maybe we could just

  1. add description & when press it can let user edit.
  2. add follower & following

About profile background could add when we confirm to add edit profile page in this page.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 5, 2023

➤ Sam commented:

Kenny Hung, sure. Let's wait what's Tammy Yang, think about that.
Once it's approved from above I can implement whatever is given. 😇

Also would be nice to give some raw drawings so I can better imagine what is expected. Describing UI with text is bit difficult to image.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 5, 2023

➤ Kenny Hung commented:

Sam Thanks for remind. This is my proposal. (Need Tammy Yang's confirmation.)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 5, 2023

➤ Tammy Yang commented:

Our rule: No Figma design can remove the existing feature. Any task with the purpose of “fit Figma” should not touch the removal of the feature.

Therefore, please KEEP activities and inbox at the original place (don't move it)

In this case, Kenny Hung 's suggestion to allow users press and edit the description is good. We should have an edit icon to notify users that this is editable. Same for the background.

No need for follow/following yet.

To summarize:

  1. Keep the activities and inboxes
  2. There will not be edit button
  3. Press description to edit profile description (needs to limit characters, need to confirm with backend)
  4. Press description to upload background (need to confirm with backend)

Because there is no such fields of user profile in the backend, I suggest reschedule the task.

Kenny Hung you can check dbdiagram next time so that you will know in order to complete this task, we need to open the task for backend first.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 5, 2023

➤ Tammy Yang commented:

Screenshot of the User table from dbdiagram ( https://dbdiagram.io/d/604602f2fcdcb6230b2311fe )
As you can see, there is no background nor user description yet.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Kenny Hung commented:

Tammy Yang (cc Sam ) Thanks for clarify.
Another question, about the background edit icon where we should add in profile page? (Because on figma design, it's in the profile edit page instead of profile page.)

@sync-by-unito sync-by-unito bot changed the title Continue "Fit figma - Edit profile page" #3, #4 [FR] Add edit feature for user description & background img on profile page Jan 6, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Tammy Yang commented:

Kenny Hung for the background, refer to Facebook. When viewer is the owner of that profile, show an edit icon.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Tammy Yang commented:

I think FB shows the convention of these features. Just follow the UI of it.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Kenny Hung commented:

Sam (cc Tammy Yang)
There is facebook UI.
I think we could add edit icon on the profile page like this screenshot.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 9, 2023

➤ Tammy Yang commented:

Agreed!

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 3, 2023

➤ Sherry Chung commented:

Kenny Hung (cc Tammy Yang ) please mapping this to exiting Roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants