Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v221125-capture-app-ionic #2334

Closed
sync-by-unito bot opened this issue Nov 24, 2022 · 22 comments
Closed

v221125-capture-app-ionic #2334

sync-by-unito bot opened this issue Nov 24, 2022 · 22 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 24, 2022

﹍Product code:﹍ capture-app

﹍Release milestone:﹍ v221125

﹍Testing level:﹍ D. Issue fix retest

﹍Release note:﹍✓ v221125-capture-app-ionic

﹍Expectation:﹍https://github.com/numbersprotocol/capture-lite/blob/master/CHANGELOG.md#0693---2022-11-28

﹍Known Issue:﹍ N/A

﹍Limitation:﹍ N/A

﹍Test Link﹍: https://github.com/numbersprotocol/capture-lite/releases/tag/0.69.3

﹍Note:﹍ N/A

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

  • A. Full test + backward compatibility
  • B. Full test, no backward compatibility
  • C. Feature test
  • D. Issue fix retest
  • E. Growth

┆Issue is synchronized with this Asana Milestone by Unito
┆Created By: Sam

@sync-by-unito sync-by-unito bot changed the title v221124-capture-app-ionic v221125-capture-app-ionic Nov 24, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 24, 2022

➤ Kenny Hung commented:

Sam (cc Tammy Yang) If [issue] filter setting will disappear on new caption edit process ( https://app.asana.com/0/inbox/1201776223124520/1203432991622346/1203433293653186 ) needs too much time to fix, please make sure [FR] Allow users to archive assets from Capture App ( https://app.asana.com/0/inbox/1201776223124520/1202798342707582/1203433293653186 ) could be fixed & release at least.
Because only remove feature is a blocking issue.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Kenny Hung, 2 tasks are done
#1 ✓ [FR] Allow users to archive assets from Capture App ( https://app.asana.com/0/0/1202798342707582 )
#2 ✓ [FR] Network action result url should display asset profile link instead of direct iframe prod link ( https://app.asana.com/0/0/1203432854732330 )

The other 2 tasks more related to iframe fix
#3. [issue] filter setting will disappear on new caption edit process ( https://app.asana.com/0/0/1203432991622346 ) (I explained in claap inside card)
#4 [FR] When the prod is unpublish, the NUM price should be turn back to "UNLIST" ( https://app.asana.com/0/0/1203432297684037 )

Kenny Hung, once Bofu Chen finishes code review for PR1 ( #2339 ) and PR2 ( #2336 ) we can submit 0.69.3 today.

For #3 and #4 we can move to the next capture iframe release.

Kenny Hung, let me know what you think

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Sam (cc Tammy YangScott YanSherry Chung) Sounds good. QA will add an additional test next Monday.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 27, 2022

➤ Bofu Chen commented:

PR1 needs more input from Sam, and please refer to my comment ( https://app.asana.com/0/0/1202798342707582/1203443897966864/f ).

PR2 has been merged.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Kenny Hung commented:

Sam (cc Bofu Chen) QA need confirm, could v221125 release before 4 p.m. today?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Sam commented:

Kenny Hung I can try. But

Iframe flash and focus can not be delivered

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Bofu Chen commented:

Sam The release plan is the same, and I'm waiting for your reply of PR1 to decide should I accept the workaround or not.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Kenny Hung commented:

Sam (cc Bofu Chen) As I know, the first priority about this release, just [FR] Allow users to archive assets from Capture App ( https://app.asana.com/0/1201016280880500/1202798342707582/f ) if this could be fixed, other items could be postpone to tomorrow release or sprint in the future.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Sam commented:

Kenny Hung, I misunderstood. Items for v221125-capture-app-ionic can be delivered today until 4 pm.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Bofu Chen commented:

Kenny HungSam CI system is building 0.69.3, and you can follow up the latest status here

https://github.com/numbersprotocol/capture-lite/actions/runs/3563424702 ( https://github.com/numbersprotocol/capture-lite/actions/runs/3563424702 )

@sync-by-unito sync-by-unito bot closed this as completed Nov 28, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Bofu Chen commented:

Sam Please help update the status of the 2 opening dependencies. Thanks!

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Sam commented:

Bofu Chen yep. Will update dev status. They are more related to iframe developmen

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Kenny Hung commented:

Sam Just confirm, about this part "Fix Android Store uploading error by updating Android API to version 32 (#2325)" how qa verify this fixed?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Sam commented:

Kenny Hung if it can be uploaded to play store then it’s fixed.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Kenny Hung commented:

Sam sorry, another question.
"Improve camera zoom in/out sensitivity", is this related to ✓ [issue] zoom in/out should be zoom in a little when the slider bar just move a little bit ( https://app.asana.com/0/0/1203175811194125 ) ?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Sam commented:

Kenny Hung yes 😇

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Bofu Chen commented:

Sam When I receive a GitHub pull request, sometimes I also need to figure out what's the targeting task of the PR.

My suggestion for process improvement is

  1. When Sam opens a PR, GitHub (Unito) will create a mirroring Asana task automatically.
  2. Sam adds the auto-generated task to the targeting task's dependencies (blocking the targeting task).

The benefit: QA and release manager can find the relationship between the PR and the targeting task quickly.

What do you think?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 28, 2022

➤ Sam commented:

Bofu Chen understood. I think it’s a better option. Last few PRs #2344 ( #2344 ) I was manually adding asana task.

Thank you for hint. I will add auto generated tasks as dependencies. 🙏

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 29, 2022

➤ Kenny Hung commented:

Sam about 0.69.3, Fix NUM price status after a product is unlisted (#2336)
I remember this item haven't been fixed

@sync-by-unito sync-by-unito bot reopened this Nov 29, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 29, 2022

➤ Tammy Yang commented:

Sam reminder, since this has been re-released, thos milestone task should be completed

@sync-by-unito sync-by-unito bot closed this as completed Nov 29, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 29, 2022

➤ Sam commented:

Tammy Yang understood will keep up to date task statuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants