-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit figma - Prod page #2228
Comments
➤ Ethan Wu commented: Kenny Hung if you look at the design it looks like there a background of the photo behind the photo with opacity and gradient. are we looking to add that for ourselves? padding: |
➤ Ethan Wu commented: Kenny Hung could we get the share icon from noir? |
➤ Ethan Wu commented: caption => done registration time => not exposed by backend. created asana card |
➤ Kenny Hung commented: Ethan Wu Waiting for Noir. BTW, I found the asset page's share icon is the same, maybe Sam has this one? |
➤ Ethan Wu commented: Sam can you provide the share icon with me? |
➤ Sam commented: Ethan Wu share icon 👆 |
➤ Ethan Wu commented: share icon changed. Kenny Hung |
➤ Kenny Hung commented: Title & Registered time will implement in the future sprint. Other part is okay, Conditional pass. |
➤ Kenny Hung commented: We will not implement "title" yet. I am not convinced yet the majority people will add both "title" and "caption" for their work shared on social media. |
➤ Sherry Chung commented: Kenny Hung (cc Ethan Wu) How about we split the "Title (Subject)" & "Registered time" request into 2 different FR then close this one? Since there already some items been updated & deployed. |
➤ Ethan Wu commented: Kenny Hung comments for this one:
|
➤ Kenny Hung commented: Yes, just add registration under creator username. |
https://docs.google.com/presentation/d/1u6-l_xDVBcPc708B3TR13DBKAoySjfKu7Hp-PGkfni0/edit#slide=id.g1706700024b_0_91
Share icon is differentImg / video should have some peddingWhen caption is too long will display “Show more”(this done on v221101)User story
As a capture app user, I want the updated prod page which fit figma design, so that I could feel the brand design is consistent.
┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung
The text was updated successfully, but these errors were encountered: