Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v221129-authmedia Make sure the signature used in Multi-uploader and CC is correct #2159

Closed
sync-by-unito bot opened this issue Oct 6, 2022 · 17 comments
Closed

v221129-authmedia Make sure the signature used in Multi-uploader and CC is correct #2159

sync-by-unito bot opened this issue Oct 6, 2022 · 17 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 6, 2022

More details see parent task and https://dt42-numbers.slack.com/archives/C3CHPJTS4/p1665038836912919

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 6, 2022

➤ Ethan Wu commented:

asset: bafybeihcizd3wo5qbd3fiuhtakqg5j7tyeew4ftvpsr5nufcb5poae2mai

proof_hash: 59aee2c44b3fa535fef25ad3142e413b01c75a5f6552c8f71ed899523eb43ca3

"signature": [
{
"provider": "CaptureClub",
"proofHash": "59aee2c44b3fa535fef25ad3142e413b01c75a5f6552c8f71ed899523eb43ca3",
"signature": "0xf6143733f8b588ff3b84c105f6fdd3a505af88434a80f92f6969fb033b9e4f537014ac34f82ff4a393e832c76d9ca2d58ff18d13fedaf10e22ee74185c2529c71c",
"publicKey": "0xe72bcD8fD77527749a7C3eA89E2Ad48E2A34aF52"
}
]

Bofu ChenTammy Yang the proof_hash are the same

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 6, 2022

➤ Tammy Yang commented:

nit signature created

[{

"integrityHash": "b12d1f5b4653e4f2095c674c9ae8e6b43eed513a811cd3733a50be97788536c0",
"provider": "nit",
"signature": "0x197e79174db7b87599d825e2bd63590bcad74d43beaa6e92c34d57323221963e57e88a8eacb17262bb934f4438c6f06aa5ab6f002951d9a959438d07105f46101b",
"signer": 0x63B7076FC0A914Af543C2e5c201df6C29FCC18c5"
}]

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 6, 2022

➤ Tammy Yang commented:

Ethan Wu can you please do me a favor?
Try if assets created by this API call can be seen in Capture App or not.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 6, 2022

➤ Tammy Yang commented:

According to Bofu Chen's comment in the parent task, I believe proofHash is actually not relevant at all.

We have new and better ways to assure the integrity.

What we can do

  1. Confirm if proofHash is the root cause stop Captures being shown in the App
  2. [Long-term] If yes, ask Sam to remove this from the next release (i.e. no matter Captures with proofHash or not, they can be shown starting from the next release)
  3. [Short-term] keep the existing proof hash used in the CaptureClub. Since it's not relevant, it doesn't matter if we put something wrong 😆 HOWEVER, we still need to update signature as mentioned in the parent task, create a metadata for the application then create the signature for it => this gives the "signature" a meaning that "The signature of the metadata of the application"

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 6, 2022

➤ Tammy Yang commented:

Suggested metadata to be signed

{
 "information": [
 {"provider": "Numbers Uploader", 
 "name": "version", 
 "value": "v1"}
 ]
}

Next:

  1. Bofu Chen please provide the nit signature for it
  2. Tammy should create the correct signature based on Bump @capacitor/cli from 2.2.1 to 2.3.0 #1 with any proofHash
  3. Ethan Wu can help update Bump protractor from 5.4.4 to 7.0.0 #2 to CaptureClub and multi-uploader

After this is done, the Captures should be able to show in the App no matter App is updated or not.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 6, 2022

➤ Ethan Wu commented:

the issue was the metadata didn't match the signed metadata. it now shows up properly.

Sam doesn't need to change any parameters on his end and it will show up.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 6, 2022

➤ Tammy Yang commented:

I think it's still good to update the Signature, but we can do it in the next sprint. Thank you for clarifying the issue!

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Ethan Wu commented:

Tammy Yang will be working on this one. if so than i think we need to make a decision on what the signature should be.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Tammy Yang commented:

Metadata

{"information": [{"provider": "Numbers API", "name": "version", "value": "v2022"}, {"provider": "Numbers Co., Ltd.", "name": "API version", "value": "v2"}]}

Signature

[{ "integrityHash": "b12d1f5b4653e4f2095c674c9ae8e6b43eed513a811cd3733a50be97788536c0", "provider": "nit", "signature": "0x197e79174db7b87599d825e2bd63590bcad74d43beaa6e92c34d57323221963e57e88a8eacb17262bb934f4438c6f06aa5ab6f002951d9a959438d07105f46101b", "signer": "0x63B7076FC0A914Af543C2e5c201df6C29FCC18c5" }]

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Tammy Yang commented:

Let's use the same as Numbers API (since all captures are created via API)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Tammy Yang commented:

Reference from Numbers API Bubble App

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 22, 2022

➤ Kenny Hung commented:

Ethan Wu Please help to update this task progress, thanks.
If it haven't been finished, does this task drop?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 22, 2022

➤ Ethan Wu commented:

Kenny Hung sorry i missed the comments made by tammy. you can move this task to 11.21 sprint release

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 29, 2022

➤ Ethan Wu commented:

Updated Multi-Uploader Signature & Metadata

{
"id": "bafybeidde2yrpzsfbi4awsm3u6q5fq4zwupyzxufk3m4ake2xidfpgwrsi",
"uuid": "d4d79393-de4e-40e1-9b19-70bf1998b102",
"cid": "bafybeidde2yrpzsfbi4awsm3u6q5fq4zwupyzxufk3m4ake2xidfpgwrsi",
"type": "unique",
"asset_file": "https://dia-cdn.numbersprotocol.io/files/2022/11/29/14/18/18/LJyczvFtLtatZtb6ZtCo_314617021_10159148186481662_8527365659439185121_.jpeg?Expires=1669990698&Signature=J7v~BUq6ES6c29DShhvrFFfWHPMMRQkdafXDJl87aplzH~rKuLB92GJ~uuAM6zGZnE9DLzvuwVkMOpm9MBSC5Hwk4VyrfMn31oC2N5QzW3H-PIjP0BzTu5zVZYVCnXxtVEjQbmv0P2tMBprDXtD-OTc6xW5K0G0mIysNCoxWNkCiIuXoMmjta5J2Et7BGW~Yg3CN1BMATbmYQpFuUsdztf3kF3bZZ4EvTF412h2sUW06BO0P0F-xix-Os2zyrWg~cilr73GLJvshsJHnP~pkyOPJcT6hwbFlOcFReQnnePWquZxpdjad8y-Z3HaZ60Kn9cWXHkHhP06czgJ0Z0Vj-w__&Key-Pair-Id=KBYPQEH39GYAO",
"asset_file_url": "",
"asset_file_name": "314617021_10159148186481662_8527365659439185121_n.jpeg",
"asset_file_size": 371185,
"asset_file_mime_type": "image/jpeg",
"asset_file_snapshot": "https://dia-cdn.numbersprotocol.io/files/2022/11/29/14/18/21/jZtXOf4ngVzDZ9pHv0Uo_314617021_10159148186481662_8527365659439185121_.jpg?Expires=1669990794&Signature=MVjinRRKhafa9FVszs-FRrIgLQvki6pPzPJIrztMVyPuquoiMZRF7DP8zmVl8PiPcfkmckPQShQbte9GOOQC5NFZPGvaddzCd-guW6mghqmp4FltWcXkw2dKS32tSLSxarsKTdKhqMLp7SoBClWg5g7IlliBQ-NfYqS1QfFkPaBKLLLR6pgYLR45XIHDDOBcSIdDgAI6Gfj5StB4aToCa5e5xr5igruruf6JekcZodW-LuVGyqS63CoawvZVCMrGC9Zn~SOo-Um2UGjc~I7K6c9pb3aWvcr4lwACURWMpBKs2wqZ11OSmOeMhBEjOn0YIohYpSDyfJLRyxNVsQyXKA__&Key-Pair-Id=KBYPQEH39GYAO",
"asset_file_snapshot_url": "",
"asset_file_thumbnail": "https://dia-cdn.numbersprotocol.io/thumbnails/2022/11/29/14/18/23/So9tsAJzeWvee5tYXYSM_314617021_10159148186481662_8527365659439185.jpg?Expires=1669990794&Signature=vAkVELCaimSabdey5E~OYuHhWfIUwDsMGKRk0OCLkUPQyxG-4iinI0ktzo-J8tQYAOCcYOzQnXWoqlkaM-bKa5B7d4xSI9fMusEIjollDf7Ns-rg1AVZQNVBTUbcPsKPiC1Svc83IiFXyI4ba2AcwmVncosDYZn7oMqUnfT0isYqsvO5k2s9tHmKkpZ5SJRHOvdFMxYy6KU3OfssPZhdrDjF29OcyWCzIZNEIzrG40D67qrzAqYiO6JPAY9pDXhvx5uXm2TUJBzdQySZTGcHc3wuecPjIdeTe0S0C2SHeHlG05IO9jg13V8QeQNdjXxnLGckSORdV1GLV1zIBeD6wA__&Key-Pair-Id=KBYPQEH39GYAO",
"sharable_copy": "https://dia-cdn.numbersprotocol.io/thumbnails/2022/11/29/14/18/23/050Js2diNmjmgi4bOtS1_314617021_10159148186481662_8527365659439185.jpg?Expires=1669990794&Signature=NOOc6OsoaF8ZIQNt1Y5sSTD3tsk57vmGtW6HL7sBJ-OL2NcnRDpoC89CuEHjRcITUJZ39jJm-uk9MESv0siFbRzossANlyQ13F2kCaOLbqZGYVenZkEMfzCEwRfMFbYJU8OufCPKWFWFvBmhxvEsbxLP9VFJ1Nc3IwFMTwd~7~d3pN1uwAcukzM0HN4VENGOR1bcGDB5X3fGClxYhjmELFv~OVFa5VWoOkU0gxI86nIYcLY7EBHaT5pZAr2Aoqjg2KvYUaukZ9mliiIcmpfrCWUddaopu1R39~bTVMg2O8gSIdP~fq-sk4P6ybok4~peH-xuanboAakZGbHX-4or-A__&Key-Pair-Id=KBYPQEH39GYAO",
"supporting_file": "",
"supporting_file_mime_type": "",
"supporting_file_thumbnail": null,
"integrity_providers": [
"iota_chrysalis"
],
"integrity_info": [
{
"integrity_provider": "iota_chrysalis",
"search_id": "64a4ec24bb084cd9018b49a69a517c73662a0a6b0ab19fc936af02fc0b377004",
"search_index": "bafybeidde2yrpzsfbi4awsm3u6q5fq4zwupyzxufk3m4ake2xidfpgwrsi",
"explorer_url": "https://explorer.iota.org/mainnet/message/64a4ec24bb084cd9018b49a69a517c73662a0a6b0ab19fc936af02fc0b377004",
"created_at": "2022-11-29T14:18:53.232592Z"
},
{
"integrity_provider": "iota_chrysalis",
"search_id": "f1393f9435e6ee98d49824044dfbd4a81be86ad8f1b17cf543f3cb8260e510c3",
"search_index": "bafybeidde2yrpzsfbi4awsm3u6q5fq4zwupyzxufk3m4ake2xidfpgwrsi",
"explorer_url": "https://explorer.iota.org/mainnet/message/f1393f9435e6ee98d49824044dfbd4a81be86ad8f1b17cf543f3cb8260e510c3",
"created_at": "2022-11-29T14:18:44.061860Z"
}
],
"integrity_verification_hash": "",
"integrity_verification_tag": "",
"proof_hash": "726a03d2790b8495d0fc206990e24efe4edf8afa229b3e5014ab4fb5ea4494f0",
"cai_file": "https://dia-cdn.numbersprotocol.io/cai_images/2022/11/29/14/18/45/ztjMsRYAYQxEzc4b8Sdo_314617021_10159148186481662_8527365659439185.jpg?Expires=1669990794&Signature=T4m68~c70OYb41hWXAL3Bt6u55ruX-y7PcZrLIITz2-1nlqzjywPl2f5HxLbfMrBKz67~jueXTUbYXvFPVQal1AAcEVTek4NUOyOjsj8~XyL7hzKbcUZAcqFnuhpaJJwH~6hqBrmtkb1a2ZELJ5Fl4fGamEKnAfQ4tnhUvp5vqu7t-nHzm9PGgX3JOmhFx7XsJm2dmwOSbodKQlKBuq9uKpuQI25Rcu4u~WvkkHjpc9769JkfHQpRHdzJ-LQj2YWM-wR0T1LFoDiIFRlv8WTTCWH2I~gm5~Tk0H~OLaV81RIWQUqLsmQpWEV1BF9zWGr77u2Oo-JCpmlBYPVu2yIYA__&Key-Pair-Id=KBYPQEH39GYAO",
"cai_file_url": "https://ipfs.io/ipfs/bafybeibhobpry4pmyu2iiqloropyk3atlxo2lkrbaaymqz23xsy4ro6nyq",
"nft_spec": "erc721",
"nft_token_id": null,
"nft_token_uri": "",
"nft_creation_tx_hash": "",
"nft_chain_id": null,
"nft_blockchain_name": "",
"nft_contract_address": "",
"caption": "",
"tag": "",
"information": {
"proof": {
"hash": "726a03d2790b8495d0fc206990e24efe4edf8afa229b3e5014ab4fb5ea4494f0",
"mimeType": "image/jpeg",
"timestamp": 1669731440000
},
"information": [
{
"provider": "CaptureClub",
"name": "version",
"value": "2021.09.02"
},
{
"provider": "CaptureClub",
"name": "API version",
"value": "v3"
}
]
},
"signed_metadata": ""{\"information\": [{\"provider\": \"Numbers API\", \"name\": \"version\", \"value\": \"v2022\"}, {\"provider\": \"Numbers Co., Ltd.\", \"name\": \"API version\", \"value\": \"v2\"}]}"",
"metadata_cid": "bafkreif2hln4zm3lf7mb2bf7c4olzlqvr3zssj5vfqodmuuzinl6ptvy4e",
"signature": [
{
"provider": "CaptureClub",
"proofHash": "726a03d2790b8495d0fc206990e24efe4edf8afa229b3e5014ab4fb5ea4494f0",
"signature": "0x03d7582801f40798fa97036f9963da3d87d2ac395196062161136bc42a4cb2b91df324c33a0fcd3085886bd3c77d8cc266e026a8c05d00680f7523d360c5004c1c",
"publicKey": "0xe72bcD8fD77527749a7C3eA89E2Ad48E2A34aF52"
}
],
"owner": "[email protected]",
"owner_name": "hinoki",
"owner_addresses": {
"asset_wallet_address": "0xD2426cF9244D0ce05696B3c945ef069264f30b4A",
"managed_wallet_address": "0xb445A077E176B3312129dE931C5891D1DCEa9CB3"
},
"creator": "[email protected]",
"creator_name": "hinoki",
"creator_addresses": {
"asset_wallet_address": "0xD2426cF9244D0ce05696B3c945ef069264f30b4A",
"managed_wallet_address": "0xb445A077E176B3312129dE931C5891D1DCEa9CB3"
},
"parent_asset": null,
"source_type": "original",
"source_transaction": null,
"is_original_owner": true,
"task_id": null,
"post_creation_workflow_id": "e7f8e014-c584-464e-8465-a5a4d3ce1b07",
"mint_workflow_id": null,
"verification_result": "basic",
"certified_asset": "https://dia-cdn.numbersprotocol.io/certified_assets/2022/11/29/14/18/54/rSRLWNo64fdYF4h0GZjD_314617021_10159148186481662_8527365659.jpg?Expires=1669990794&Signature=BuqgM5c7LaOJWPzk2r3lDRNLOfM8TKYYLCKen5MvXig8vLF5yygHcuVpuUVQqU1oVFcZjGoQwKIcXCifCE9Rt~g8OmFUuw~0xlbhgBvMT-kANscafJbFSRrn8qWDBffEkX3RA89qpaXvYwQcU5CMOfXBP8w~m54T6vvG6i3ycVaiv6fAuLzsi17mCgXIT~Qx1NYn04yA8ivIbYKV~kb~c7JzePzkZBmF5jNliCzYPgTyBBnJGGf0Gr9EAYmJ1JxLmlAEDmDJ7RnWWr5-nm4V1F0s-DpdFWTkaqEVfaJVWrVcpBfT4kGIj8xQwiQxNzG5lN7n-dsZ3Rtvrqj8aEbaTw__&Key-Pair-Id=KBYPQEH39GYAO",
"certified_asset_mime_type": "",
"certified_asset_thumbnail": "https://dia-cdn.numbersprotocol.io/thumbnails/2022/11/29/14/18/55/OzRgsMtTPqrMtruQ2S1y_314617021_10159148186481662_8527365659.jpg?Expires=1669990794&Signature=QTRGUq-YI6TWDH3vnHn~Yvq5fiCqVHiQIgxI90urojg9Jsx5-XokBioJLLMXTQoV595ApLdqlqk3xX~i5ubT8AJkZWtU41rts7ii67AZa2Dtol-UUw2NnsOmbyUd4aZi23gSiDpKJ2bXZcFpPOzFumpW1WngExLo9qrNtiQ743AQoT3qMTkspcpefqGgYhE3w0s6FSOhJNNeu5rLoe88vGUh7uzWng3utzioIn-qZEbof8Eu-3XCOU0K-kM6p48sTs6dACpiE8ZhCYL85vesFefNaJkBS7KVWumPzGM~-OMELrWfH0du6DkFWHLOp17AVfEQUMQ9bYPljl0Z72j08w__&Key-Pair-Id=KBYPQEH39GYAO",
"certificate_qrcode": "https://dia-cdn.numbersprotocol.io/qrcode/2022/11/29/14/18/19/FpS3YKjxLWvXmKPG0xH8_qrcode.png?Expires=1669990794&Signature=BeYIjas2ybDHVHMaOrsTW7x0BybkfTIAuWnrSWumeS1lSK7sTH-dmgrt0o9OwcMqkUf9Uh4tMKGqnzyN-w-yttO2tJZN18adMavvUUrRVpunOXNNMmsgoKITaaCnEmG5bwcRfFZGSR7PICKO71eLR98dw7Vs7eDveWJHboAUVuYml~KgR3IDVpiqvhqAyADADZiDmucrgNZzerYleEKUK27p6qj~QaGtoZDsjC4aR2NKT8igYx2089cvwV9BTs9xJ~hfiJJxURF~ORhPxQ0UrZaPbMzgspObPgx7-BxB~E61hU7gayB99ygu95oK6T94bRbnz0X7-IkQttupul4RVQ__&Key-Pair-Id=KBYPQEH39GYAO",
"certificate_link": "https://authmedia.net/dia-certificate?mid=d4d79393-de4e-40e1-9b19-70bf1998b102",
"protected": false,
"public_access": false,
"published": false,
"uploaded_at": "2022-11-29T14:18:09.927945Z",
"updated_at": "2022-11-29T14:18:56.053145Z",
"parsed_meta": {
"proof_hash": "726a03d2790b8495d0fc206990e24efe4edf8afa229b3e5014ab4fb5ea4494f0",
"mime_type": "image/jpeg",
"capture_time": 1669731440000
}
}

@sync-by-unito sync-by-unito bot closed this as completed Nov 29, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 29, 2022

➤ Ethan Wu commented:

verified it shows up in capture app

@sync-by-unito sync-by-unito bot changed the title Make sure the signature used in Multi-uploader and CC is correct v221129-authmedia Make sure the signature used in Multi-uploader and CC is correct Nov 30, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 2, 2022

➤ Kenny Hung commented:

Ethan Wu about this release I just make sure "signature" will like as below and it could display on capture app, right?
"signature": [
{
"provider": "CaptureClub",
"proofHash": "066ee34b55d94bc4acd2aedceeeb1e23c8b835f316eab9cf33cf1137b740193b",
"signature": "0x9459119925b7d80f0810d1f08a5d26f45953cc523ba18dcad77b4c6aa7cf5ddb76c95b185680a27f7858838928fb3de0b1ac76655f54efbd352ceee3aadd3d801b",
"publicKey": "0xe72bcD8fD77527749a7C3eA89E2Ad48E2A34aF52"
}
],

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 2, 2022

➤ Ethan Wu commented:

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants