-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue] remove the white flash when the app is first launched #2138
Comments
➤ Kenny Hung commented: Oppo / iOS light mode will happened this issue, is about ionic. |
➤ Sam commented: Just a dev status update. This issue is not simple to fix, |
➤ Sam commented: Ethan Wu, To prevent white flash can we experiment and set global styles in the bubble app to <style> body { background-color: black; } </style>But it will work on the paid plan only. |
➤ Ethan Wu commented: Sam I've added it in. can test with qa-release version of iframe |
➤ Sam commented: Ethan Wu, just to confirm should I use https://captureappiframe.numbersprotocol.io/version-v221107-ethan-from-qa/ |
➤ Sam commented: I tried this URL also https://captureappiframe.numbersprotocol.io/version-qa-release/ |
➤ Sam commented: Just dev status update: Didn't worked will try something else |
➤ Sam commented: Ethan Wu, do we have paid support from bubble? If so can we ask the bubble team about the Pageload White Flash ( https://forum.bubble.io/t/pageload-white-flash/112343 ) issue? If I could ask the bubble team I would ask "How to prevent white flash between page loads" and show them thread ( https://forum.bubble.io/t/pageload-white-flash/112343/11 )? |
➤ Ethan Wu commented: Sam yes we have a paid account. just send them a support ticket and they will respond. usually one business day |
➤ Sam commented: Ethan Wu, Which account I can use to submit a ticket? |
➤ Sam commented: Or I just can send from my personal bubble account? |
➤ Ethan Wu commented: Sam i think you can send it from your own account. just tell them project name because that is the one that is paid |
➤ Ethan Wu commented: project name is: capture-app-iframe |
➤ Sam commented: The bubble team needs more info [screenshot ( https://i.imgur.com/cRJxpe2.png )] So I prepared them sample project with shareable demo etc. Waiting for their response. Text from my last email. Sample code can be found here https://codesandbox.io/s/elated-cherry-qc7t8q?file=/index.html ( https://codesandbox.io/s/elated-cherry-qc7t8q?file=/index.html ) As you can see in this demo ( https://i.imgur.com/CkMxFtS.mp4 ) video there are some white flashes between page loads and page navigation which happens on iOS devices. So if you open on an iOS device this page https://qc7t8q.csb.app/ ( https://qc7t8q.csb.app/ ) (HTML page with bubble app inside the iframe) you can see white flashes between page navigation. We also tried setting the iframe background to black but didn't work. How we can prevent this white flash? Best regards, |
➤ Sam commented: Ethan Wu can we add update global style? Sam: @Ethan Wu, To prevent white flash can we experiment and set global styles in the bubble app to <style> html { background-color: transparent; } body { background-color: transparent; } </style>But it will work on the paid plan only. |
➤ Ethan Wu commented: Sam i can try. one sec. |
➤ Ethan Wu commented: Sam where should i add this? under the script in body section? |
➤ Ethan Wu commented: i've added it in. see screenshot. v221115 branch |
➤ Sam commented: Ethan Wu thank you I will try it |
➤ Sam commented: Kenny Hung, cc Tammy Yang, Bofu Chen Dev status update: using the background color to transparent didn't work. White flash happens in 2 cases
But after a few navigations, there are no more white flashes. So far I was able to fix flash at the app launch (case 1) but the user still gets white flash if he navigates in the explore tab. After 2,3 navigation in explore tab white flash disappeared. I was able to fix case 1 but the coding part is not elegant so I wouldn't add it to the prod code. [git diff screenshot ( https://i.imgur.com/nlFo1ri.png )]. Seems like a white flash happens at app launch only then after a while white flashes are gone. Initially, I thought that setting the iframe background color to black would resolve the issue, but it turned out to be more complex. Now, I'm waiting for the ionic team's response ( https://ionic.zendesk.com/hc/en-us/requests/44142 ). I apologize for the late response. I am still investigating this behavior and do not yet have an update on how to resolve the issue. I can test this out tomorrow and further investigate the sample repo you have provide to determine if there are any other potential solutions. Kenny Hung, can we move it to the next sprint? From now on, I will switch to camera-related issues. |
➤ Tammy Yang commented: Sam let's focus on fixing situation #1 (which according to you comment, it has been finished) |
➤ Sam commented: Kenny Hung, (cc: Tammy Yang). I even dive into @capacitor/ios and find a potential fix ( https://github.com/sultanmyrza/ios-webview-bg-experiment/blob/main/README.md ) for white flash but it will require ionic teams to make changes to their framework. The full conversation with the ionic team about the white flash issue can be found here ( https://ionic.zendesk.com/hc/en-us/requests/44142?page=1 ). |
➤ Kenny Hung commented: According to discuss from Comment by @sam on v221129-capture-app-ionic ( https://app.asana.com/0/0/1203376695669270/1203455819272863/f ), this task will be re-arrange. |
➤ Kenny Hung commented: Sam QA think this part should be also fixed on this sprint with [issue] remove the white flash when the user navigates to other captures/profiles in (Explore tab) ( https://app.asana.com/0/1201016280880500/1203389740732570/f ) and qa had been sent Oppo to you. |
➤ Sam commented: Kenny Hung iOS version is fixed therefore iOS version can be published but for android to fix I need to try to find a solution and it requires some time For this sprint I can deliver white flash for iOS and for next sprint fix white flash for android |
➤ Kenny Hung commented: Sam(cc Tammy Yang) move this task to next sprint. |
➤ Sam commented: Kenny Hung, I couldn't reproduce the white flash on the Oppo device. I tried to set dark mode to white mode but there was no white flash as you can see in the claap. https://app.claap.io/numbers-protocol/qa-oppo-can-not-reproduce-iframe-white-flash-dark-light-mode-c-O35CsUM4Uy-wni0D8yzK6NG ( https://app.claap.io/numbers-protocol/qa-oppo-can-not-reproduce-iframe-white-flash-dark-light-mode-c-O35CsUM4Uy-wni0D8yzK6NG ) |
➤ Sam commented: Kenny Hung, I couldn't reproduce the white flash on the Oppo (dark mode, light mode). |
➤ Sam commented: Just side note this issue can also be fixed by this PR ( #2423 ). |
It's from Jesse's suggestion #5.
Reproduce steps:
On any loading for iframe page, it will display the full white page before the loading finished.
User story
As a capture app user, I want the page loading without white flash so that I can feel better UX.
┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung
The text was updated successfully, but these errors were encountered: