Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild the new capture-app version for app store review #2101

Closed
sync-by-unito bot opened this issue Sep 21, 2022 · 17 comments
Closed

rebuild the new capture-app version for app store review #2101

sync-by-unito bot opened this issue Sep 21, 2022 · 17 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Sep 21, 2022

there are some issues need to fix, QA think maybe it needs rebuild new version for it.

  1. (blocking review) It display

Your app contains NSUserTrackingUsageDescription, indicating that you will request permission to track users. To update this information on your app's product page, you must indicate which data types are tracking users. If this is incorrect, update your app binary and upload a new build to App Store Connect.
QA doesn’t find any options on apple connect

  1. (option) edit the iOS compatibility, it should display iOS 14.7 or later.
    QA also can't edit this on apple connect. Maybe it should change from app.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot changed the title rebuild the new one version to sent app store review rebuild the new capture-app version to sent app store review Sep 21, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Kenny Hung commented:

It's about #2.

@sync-by-unito sync-by-unito bot changed the title rebuild the new capture-app version to sent app store review rebuild the new capture-app version for app store review Sep 21, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sherry Chung commented:

Sam (cc Tammy Yang ) For #1, it will blocking the submit to review process on App Store. But I can't find anything I can modified on submission page.
Let me know if you can alter the parameters when building App.
I can also share the submission page on Zoom meeting if that will help.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sam commented:

Sherry Chung, We can try to update our app privacy ( https://appstoreconnect.apple.com/apps/1536388009/appstore/privacy ) according to these suggestions #1 ( https://stackoverflow.com/a/69622704/6133329 ) and #2 ( https://stackoverflow.com/a/67083153/6133329 )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sherry Chung commented:

Sam I already tried but it didn't help. I can share my screen to you in Zoom meeting

For #1, already change privacy setting but the error still show
For #2, there's nothing I can change about the requirement from my side

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sam commented:

Sherry Chung, have you tried to add location privacy? Here is the claap ( https://app.claap.io/numbers-protocol/devs-only-app-store-review-issue-ns-user-tracking-usage-description-c-O35CsUM4Uy-HIFyh7fv8IpT )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sherry Chung commented:

Sam I updated the App privacy but it show the same error. Please check this page, I think it's related to this error.
https://developer.apple.com/documentation/bundleresources/information_property_list/nsusertrackingusagedescription ( https://developer.apple.com/documentation/bundleresources/information_property_list/nsusertrackingusagedescription )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sam commented:

Sherry Chung, I set NSUserTrackingUsageDescription to

"We collect your data only for counting download numbers and will never share it with any 3rd party "

in the codebase one month ago. [screenshot ( https://i.imgur.com/vNcdRr6.png )].

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sherry Chung commented:

Sam Yes!!! It just disappear. Let me try

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sherry Chung commented:

SamKenny HungTammy Yang #1 solved. (No idea what I did)
For #2, we can leave it to next build.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sam commented:

Sherry Chung, for issue #2 it can be changed from dev side [screenshot ( https://i.imgur.com/Svc3hV6.png )]

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Sam commented:

Bofu Chen, I think it's better to do it via GitHub actions build that way we can keep track git history.

Yes, correct we should update L370 & L395. I created PR ( #2102 ) where I changed deployment target via Xcode (safe).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Bofu Chen commented:

PR has been merged, and I'm creating 0.66.3

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 21, 2022

➤ Bofu Chen commented:

0.66.3 is ready

Tammy YangKenny Hung I will not do a release because the source code is the same. However, I would suggest QA to do simple installation and function test.

@sync-by-unito sync-by-unito bot closed this as completed Sep 22, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 26, 2022

➤ Kenny Hung commented:

Sam (cc Bofu ChenSherry Chung)
QA needs to confirm about 0.66.3, it includes 0.66.2 new feature & fixed? or just based on 0.66.1?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 26, 2022

➤ Bofu Chen commented:

0.66.3 includes 0.66.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants