Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment of MintNFT network actions #1812

Open
sync-by-unito bot opened this issue Jul 12, 2022 · 21 comments
Open

Deployment of MintNFT network actions #1812

sync-by-unito bot opened this issue Jul 12, 2022 · 21 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 12, 2022

┆Issue is synchronized with this Asana task by Unito
┆Created By: PJ

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

  1. Update the lambda function of mintnft-mainnet-async (https://us-east-1.console.aws.amazon.com/lambda/home?region=us-east-1#/functions/mintNFTv2-mainnet-async?tab=code ( https://us-east-1.console.aws.amazon.com/lambda/home?region=us-east-1#/functions/mintNFTv2-mainnet-async?tab=code )) to the current qa-tested mintnft-dev, source code is in github PR(https://github.com/numbersprotocol/lambda/pull/16 ( https://github.com/numbersprotocol/lambda/pull/16 ))
  2. Update the environmental variables of mintnft-mainnet-async (https://us-east-1.console.aws.amazon.com/lambda/home?region=us-east-1#/functions/mintNFTv2-mainnet-async?tab=configure ( https://us-east-1.console.aws.amazon.com/lambda/home?region=us-east-1#/functions/mintNFTv2-mainnet-async?tab=configure )), bubble_url should be https://numbers-upvote.bubbleapps.io/api/1.1/wf/update_order_mintnft_nftse after bubble deploy to live
  3. Since the lambda function is updated, the api call body require more parameters, change the mint-mainnet-async call to the form of mint-testnet in bubble → plugin → API connector
  4. deploy bubble qa-release to live
  5. test

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Tammy Yang Ping me if there's anything uncertain, thanks

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

PJ 第一步看不到 code

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Tammy Yang 對,lambda對於太長的code會不顯示,只能透過zip檔上傳。
在github中有如何產生zip檔的readme,可以參考

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

PJ I don't understand why dont we keep the workflow "update_order_mintnft"

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

In your way, we need to update Lambda which causes additional costs and risks.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Tammy Yang update_order_mintnft should be removed. I'm not sure if there's better way to do this

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

@pj I don't understand. If it should be removed, why don't we leverage the same name? Why do we need to use a new name "update_order_mintnft_nftse"??

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Tammy Yang sorry I misunderstand, yes we should keep update_order_mintnft, but change the workflow

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Tammy Yang I'll remove the update_order_mintnft_nftse and update update_order_mintnft workflow into the new one, then step2 can be avoided

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

PJ just to confirm

  1. We CAN keep update_order_mintnft
  2. But, you have added a new update_order_mintnft_nftse

So, If I DO NOT want to update the environment variable of #2, I can merge your change from update_order_mintnft_nftse to update_order_mintnft

Is it correct?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

PJ no need to do anything at the moment. I am just confirming because I will need to take over this task.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Tammy Yang Yes you can and it's a way safer method.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

Another question
It calls MintNFT-mint-testnet Is it correct?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

(I was in qa-release branch)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Yes, it correspond to the mintnftv2-dev lambda function
MintNFT - mint-mainnet-async correspond to mintnftv2-mainnet-async lambda function

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

However, there is no step in your hand-over manual to update Bubble to Mainnet.
I should also do it, right?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

I saw it, it's step #3

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

(Actually no, the steps were missing)

To summarize what I should do

  1. Update lambda function to the new code
  2. Rename update_order_mintnft_nftse to update_order_mintnft << so I don't need to change env variables)
  3. Update mint-mainnet-async call
  4. Update mintnft_avax, mintnft_ethereum, mintnft_polygon and change the API from testnet to mainnet << this step was missing

Is it correct?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ PJ commented:

Yes

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 12, 2022

➤ Tammy Yang commented:

OK, I think I get it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant