Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of instances displayed vs written disagree #2042

Closed
nikohansen opened this issue Nov 9, 2021 · 4 comments
Closed

Number of instances displayed vs written disagree #2042

nikohansen opened this issue Nov 9, 2021 · 4 comments
Assignees
Labels

Comments

@nikohansen
Copy link
Contributor

Like in this figure
Screen Shot 2021-11-09 at 15 35 58
which was generated for a paper.

We see 10 steps in the ECDF, but 15 instances written. Why?

See also #1972, #1117.

@brockho
Copy link
Contributor

brockho commented Nov 9, 2021

After quite some experimentation, I found the cause: The number of steps in the ECDFs is not the number of instances, but the number of bootstrapped runs. Because line 50 of genericsettings.py:

simulated_runlength_bootstrap_sample_size = 10 + 990 // (1 + 10 * max((0, in_a_hurry)))  # for tables and plots

evaluates to 10 with the default setting of in_a_hurry, we see only 10 (simulated) runs in the figure. Changing line 50 to, for example, 7 and with pprldmany_target_values=[1e-3] in testbedsettings.py gives the following output with the ALPS data set:

image

@brockho
Copy link
Contributor

brockho commented Nov 9, 2021

Update: I also found the same line
settings.simulated_runlength_bootstrap_sample_size = 10 + 990 / (1 + 10 * max(0, settings.in_a_hurry))
within config.py...

@nikohansen
Copy link
Contributor Author

Excellent, thanks, that means we should probably better use the maximum of the number of trials and number of bootstraps. We still need to fix #1972 at some point, I believe I have already some code around.

@nikohansen
Copy link
Contributor Author

Should be fixed in the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants