Skip to content

Conversation

@gmarkall
Copy link
Member

@gmarkall gmarkall commented May 30, 2025

Using this PR for development / notes.

Build / installation

I built for linux-64 with the GHA builder (https://github.com/numba/llvmlite/actions/runs/15325329108)

Installation requires:

  + liblzma-devel    5.8.1  hb9d3cd8_1          conda-forge                             442kB
  + xz-gpl-tools     5.8.1  hbcc6ac9_1          conda-forge                              34kB
  + xz-tools         5.8.1  hb9d3cd8_1          conda-forge                              96kB
  + libstdcxx-ng    15.1.0  h4852527_2          conda-forge                            Cached
  + zlib            1.2.13  h4ab18f5_6          conda-forge                            Cached
  + xz               5.8.1  hbcc6ac9_1          conda-forge                              24kB
  + zstd             1.5.6  ha6fb4c9_0          conda-forge                            Cached
  + llvmdev         20.1.5  hfc4b9b4_0          /home/gmarkall/numbadev/llvmdev-20      684MB

@gmarkall
Copy link
Member Author

gmarkall commented Jun 3, 2025

Are the zlib and zstd dependencies a problem?

Yes, for wheels. Different recipe versions may be needed for wheels and conda packages.

@seibert
Copy link
Contributor

seibert commented Jun 3, 2025

I think #1227 should fix the issue you saw when you ran the build with GitHub Actions. You might need to merge main into this branch to pick up the fix.

@gmarkall
Copy link
Member Author

gmarkall commented Jun 4, 2025

Thanks, will give it a try!

@gmarkall gmarkall added this to the v0.45.0 milestone Jun 24, 2025
Required changes:

- Update LLVM version and SHA.
- Don't apply patches we used with LLVM 15.
- Remove `conda_build_config.yaml` that specified old compilers
- Don't build libunwind on Linux - it may no longer be necessary (it was
  added to ensure we had a compatible libunwind for the LLVM 14 build),
  and triggers a build issue due to a GCC bug, like:
  llvm/llvm-project#90332
@stuartarchibald
Copy link
Contributor

As noted in OOB discussion, this patch needs to re-enable building with assertions "on" for the purposes of Numba channel releases/development builds.

Further, I'm not sure whether this needs to build with RTTI, I recall historically that it was "off" but it seems to have been set to "on" recently.

@gmarkall gmarkall marked this pull request as ready for review August 20, 2025 10:22
@esc
Copy link
Member

esc commented Aug 20, 2025

Looks like the wheel builds are failing with:

Applying patch: /root/llvmlite/conda-recipes/llvmdev_for_wheel/../llvm15-clear-gotoffsetmap.patch
Applying patch: /root/llvmlite/conda-recipes/llvmdev_for_wheel/../llvm15-clear-gotoffsetmap.patch with args:
['-Np1', '-i', '/tmp/tmpmw4obdaz/llvm15-clear-gotoffsetmap.patch.native', '--binary']
Warning: failed to download source.  If building, will try again after downloading recipe dependencies.
Error was: 
Command '['/root/miniconda3/envs/buildenv/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmpmw4obdaz/llvm15-clear-gotoffsetmap.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.

and so far none of the builds have succeeded yet, they have all failed in one capacity or another.

As a first step I would suggest to remove the llvm15 patch application and then track down the rest of the issues.

@esc
Copy link
Member

esc commented Aug 20, 2025

A few llvmdevs have built fine:

  • linux-64
  • linux-aarch64
  • win-64

swap357 and others added 5 commits August 20, 2025 13:24
* main:
  simplify conda build command, remove CONDA_BUILD_SYSROOT variant arg
  update MACOSX_SDK_VERSION to 10.15 and set CONDA_BUILD_SYSROOT for consistency
  replace MacOSX10.10 SDK with MacOSX10.15 SDK on setup script and update checksum
@esc
Copy link
Member

esc commented Aug 21, 2025

The PR #1259 was included here via a merge to main. The PR #1262 was also included, but merged directly with this branch.

It looks promising now, no llvmdev runs have failed and we are only waiting on osx-64 and win64.

💪 💪 💪

Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on successful "Numba with LLVM 20 enabled llvmlite"-test.

@esc
Copy link
Member

esc commented Aug 26, 2025

Based on the tests in: #1092 and numba/numba#10146 -- this is now ready to merge!

@esc esc merged commit d152599 into main Aug 26, 2025
32 of 33 checks passed
@esc esc deleted the llvmdev-20 branch August 27, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants