Skip to content

Commit c2c2fef

Browse files
nukeopnukeop
committed
Update table snapshots
1 parent bae0c93 commit c2c2fef

File tree

9 files changed

+29
-62
lines changed

9 files changed

+29
-62
lines changed

‎packages/app/app/containers/AlbumViewContainer/__snapshots__/AlbumViewContainer.test.tsx.snap

-4
Original file line numberDiff line numberDiff line change
@@ -213,10 +213,6 @@ exports[`Album view container should display an album 1`] = `
213213
</div>
214214
</div>
215215
</div>
216-
<div
217-
class="track_table_header_spacer"
218-
data-testid="track-table-header-spacer"
219-
/>
220216
</div>
221217
</div>
222218
<div

‎packages/app/app/containers/DashboardContainer/__snapshots__/DashboardContainer.test.tsx.snap

-4
Original file line numberDiff line numberDiff line change
@@ -685,10 +685,6 @@ exports[`Dashboard container should display top tracks after going to top tracks
685685
</div>
686686
</div>
687687
</div>
688-
<div
689-
class="track_table_header_spacer"
690-
data-testid="track-table-header-spacer"
691-
/>
692688
</div>
693689
</div>
694690
<div

‎packages/app/app/containers/DeezerPlaylistAdapter/__snapshots__/DeezerPlaylistAdapter.test.tsx.snap

-4
Original file line numberDiff line numberDiff line change
@@ -215,10 +215,6 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
215215
</div>
216216
</div>
217217
</div>
218-
<div
219-
class="track_table_header_spacer"
220-
data-testid="track-table-header-spacer"
221-
/>
222218
</div>
223219
</div>
224220
<div

‎packages/app/app/containers/FavoritesContainer/__snapshots__/FavoritesContainer.tracks.test.tsx.snap

-8
Original file line numberDiff line numberDiff line change
@@ -329,10 +329,6 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
329329
</div>
330330
</div>
331331
</div>
332-
<div
333-
class="track_table_header_spacer"
334-
data-testid="track-table-header-spacer"
335-
/>
336332
</div>
337333
</div>
338334
<div
@@ -902,10 +898,6 @@ exports[`Favorite tracks view container should show a popup when a track is clic
902898
</div>
903899
</div>
904900
</div>
905-
<div
906-
class="track_table_header_spacer"
907-
data-testid="track-table-header-spacer"
908-
/>
909901
</div>
910902
</div>
911903
<div

‎packages/app/app/containers/LibraryViewContainer/__snapshots__/LibraryViewContainer.test.tsx.snap

-4
Original file line numberDiff line numberDiff line change
@@ -952,10 +952,6 @@ exports[`Library view container should display local library in simple list mode
952952
</div>
953953
</div>
954954
</div>
955-
<div
956-
class="track_table_header_spacer"
957-
data-testid="track-table-header-spacer"
958-
/>
959955
</div>
960956
</div>
961957
<div

‎packages/app/app/containers/PlaylistViewContainer/__snapshots__/PlaylistViewContainer.test.tsx.snap

-4
Original file line numberDiff line numberDiff line change
@@ -225,10 +225,6 @@ exports[`Playlist view container should display a playlist 1`] = `
225225
</div>
226226
</div>
227227
</div>
228-
<div
229-
class="track_table_header_spacer"
230-
data-testid="track-table-header-spacer"
231-
/>
232228
</div>
233229
</div>
234230
<div

‎packages/app/app/containers/SpotifyPlaylistAdapter/__snapshots__/SpotifyPlaylistAdapter.test.tsx.snap

-4
Original file line numberDiff line numberDiff line change
@@ -228,10 +228,6 @@ exports[`Spotfiy playlist adapter should display a Spotify playlist 1`] = `
228228
</div>
229229
</div>
230230
</div>
231-
<div
232-
class="track_table_header_spacer"
233-
data-testid="track-table-header-spacer"
234-
/>
235231
</div>
236232
</div>
237233
<div

‎packages/ui/lib/components/TrackTable/Cells/SelectionCell.tsx

+11-6
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,23 @@
11
/* eslint-disable @typescript-eslint/ban-ts-comment */
22
import React, { ChangeEvent, TdHTMLAttributes } from 'react';
33
import cx from 'classnames';
4-
import { CellProps, UseRowSelectRowProps } from 'react-table';
4+
import { Cell, Row, TableToggleRowsSelectedProps, UseRowSelectRowProps } from 'react-table';
55

66
import { Checkbox } from '../../..';
77
import { Track } from '../../../types';
88
import styles from '../styles.scss';
99

10-
const SelectionCell: React.FC<CellProps<Track> & UseRowSelectRowProps<Track>> = ({
10+
type SelectionCellProps<T extends Track> = {
11+
cell: Cell<T>;
12+
row: Row<T> & UseRowSelectRowProps<T>
13+
}
14+
15+
const SelectionCell = <T extends Track>({
1116
cell,
12-
row,
13-
getToggleRowSelectedProps
14-
}) => {
15-
const toggleRowSelectedProps = getToggleRowSelectedProps();
17+
row
18+
}: SelectionCellProps<T>) => {
19+
const toggleRowSelectedProps: TableToggleRowsSelectedProps = row.getToggleRowSelectedProps();
20+
1621
return <td {...cell.getCellProps() as TdHTMLAttributes<HTMLTableCellElement>} className={cx(styles.select_cell, styles.narrow)}>
1722
<Checkbox
1823
{...toggleRowSelectedProps}

‎packages/ui/test/__snapshots__/gridTrackTable.test.tsx.snap

+18-24
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ exports[`(Snapshot) Grid track table - empty should render correctly 1`] = `
1515
<div
1616
class="track_table_header_row"
1717
role="row"
18-
style="grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 1fr 6em auto;"
18+
style="grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em auto;"
1919
>
2020
<div
2121
class="track_table_header_cell"
@@ -33,8 +33,13 @@ exports[`(Snapshot) Grid track table - empty should render correctly 1`] = `
3333
>
3434
<div
3535
class="text_header centered"
36+
data-testid="position-header"
3637
>
3738
Position
39+
<i
40+
aria-hidden="true"
41+
class="sort content ascending icon text_header_icon"
42+
/>
3843
</div>
3944
</div>
4045
<div
@@ -68,10 +73,6 @@ exports[`(Snapshot) Grid track table - empty should render correctly 1`] = `
6873
class="text_header"
6974
>
7075
Title
71-
<i
72-
aria-hidden="true"
73-
class="sort content ascending icon text_header_icon"
74-
/>
7576
</div>
7677
</div>
7778
<div
@@ -137,10 +138,6 @@ exports[`(Snapshot) Grid track table - empty should render correctly 1`] = `
137138
</div>
138139
</div>
139140
</div>
140-
<div
141-
class="track_table_header_spacer"
142-
data-test-id="track-table-header-spacer"
143-
/>
144141
</div>
145142
</div>
146143
<div
@@ -179,7 +176,7 @@ exports[`(Snapshot) Grid track table - example data with all rows should render
179176
<div
180177
class="track_table_header_row"
181178
role="row"
182-
style="grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 1fr 6em auto;"
179+
style="grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em auto;"
183180
>
184181
<div
185182
class="track_table_header_cell"
@@ -197,8 +194,13 @@ exports[`(Snapshot) Grid track table - example data with all rows should render
197194
>
198195
<div
199196
class="text_header centered"
197+
data-testid="position-header"
200198
>
201199
Position
200+
<i
201+
aria-hidden="true"
202+
class="sort content ascending icon text_header_icon"
203+
/>
202204
</div>
203205
</div>
204206
<div
@@ -232,10 +234,6 @@ exports[`(Snapshot) Grid track table - example data with all rows should render
232234
class="text_header"
233235
>
234236
Title
235-
<i
236-
aria-hidden="true"
237-
class="sort content ascending icon text_header_icon"
238-
/>
239237
</div>
240238
</div>
241239
<div
@@ -301,10 +299,6 @@ exports[`(Snapshot) Grid track table - example data with all rows should render
301299
</div>
302300
</div>
303301
</div>
304-
<div
305-
class="track_table_header_spacer"
306-
data-test-id="track-table-header-spacer"
307-
/>
308302
</div>
309303
</div>
310304
<div
@@ -325,9 +319,9 @@ exports[`(Snapshot) Grid track table - example data with all rows should render
325319
class="grid_track_table_row"
326320
data-rbd-draggable-context-id="1"
327321
data-rbd-draggable-id="0"
328-
data-test-id="track-table-row"
322+
data-testid="track-table-row"
329323
role="row"
330-
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 1fr 6em;"
324+
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em;"
331325
tabindex="0"
332326
>
333327
<div
@@ -468,9 +462,9 @@ exports[`(Snapshot) Grid track table - example data with all rows should render
468462
class="grid_track_table_row"
469463
data-rbd-draggable-context-id="1"
470464
data-rbd-draggable-id="1"
471-
data-test-id="track-table-row"
465+
data-testid="track-table-row"
472466
role="row"
473-
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 1fr 6em;"
467+
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em;"
474468
tabindex="1"
475469
>
476470
<div
@@ -611,9 +605,9 @@ exports[`(Snapshot) Grid track table - example data with all rows should render
611605
class="grid_track_table_row"
612606
data-rbd-draggable-context-id="1"
613607
data-rbd-draggable-id="2"
614-
data-test-id="track-table-row"
608+
data-testid="track-table-row"
615609
role="row"
616-
style="position: absolute; left: 0px; top: 84px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 1fr 6em;"
610+
style="position: absolute; left: 0px; top: 84px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em;"
617611
tabindex="2"
618612
>
619613
<div

0 commit comments

Comments
 (0)