Skip to content

Commit 4e10741

Browse files
nukeopnukeop
committed
Fix typo - data-test-id -> data-testid
1 parent 6f9213d commit 4e10741

File tree

13 files changed

+52
-38
lines changed

13 files changed

+52
-38
lines changed

‎packages/app/app/containers/AlbumViewContainer/__snapshots__/AlbumViewContainer.test.tsx.snap

+5-4
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ exports[`Album view container should display an album 1`] = `
142142
>
143143
<div
144144
class="text_header centered"
145+
data-testid="position-header"
145146
>
146147
<i
147148
aria-hidden="true"
@@ -214,7 +215,7 @@ exports[`Album view container should display an album 1`] = `
214215
</div>
215216
<div
216217
class="track_table_header_spacer"
217-
data-test-id="track-table-header-spacer"
218+
data-testid="track-table-header-spacer"
218219
/>
219220
</div>
220221
</div>
@@ -236,7 +237,7 @@ exports[`Album view container should display an album 1`] = `
236237
class="grid_track_table_row"
237238
data-rbd-draggable-context-id="0"
238239
data-rbd-draggable-id="0"
239-
data-test-id="track-table-row"
240+
data-testid="track-table-row"
240241
role="row"
241242
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 4em 3em minmax(8em, 1fr) 6em 6em;"
242243
tabindex="0"
@@ -343,7 +344,7 @@ exports[`Album view container should display an album 1`] = `
343344
class="grid_track_table_row"
344345
data-rbd-draggable-context-id="0"
345346
data-rbd-draggable-id="1"
346-
data-test-id="track-table-row"
347+
data-testid="track-table-row"
347348
role="row"
348349
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 4em 3em minmax(8em, 1fr) 6em 6em;"
349350
tabindex="1"
@@ -450,7 +451,7 @@ exports[`Album view container should display an album 1`] = `
450451
class="grid_track_table_row"
451452
data-rbd-draggable-context-id="0"
452453
data-rbd-draggable-id="2"
453-
data-test-id="track-table-row"
454+
data-testid="track-table-row"
454455
role="row"
455456
style="position: absolute; left: 0px; top: 84px; height: 42px; width: 100%; grid-template-columns: 4em 3em minmax(8em, 1fr) 6em 6em;"
456457
tabindex="2"

‎packages/app/app/containers/ArtistViewContainer/__snapshots__/ArtistViewContainer.test.tsx.snap

+4-4
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ exports[`Artist view container should display an artist 1`] = `
198198
</div>
199199
<div
200200
class="track_table_header_spacer"
201-
data-test-id="track-table-header-spacer"
201+
data-testid="track-table-header-spacer"
202202
/>
203203
</div>
204204
</div>
@@ -220,7 +220,7 @@ exports[`Artist view container should display an artist 1`] = `
220220
class="grid_track_table_row"
221221
data-rbd-draggable-context-id="0"
222222
data-rbd-draggable-id="2"
223-
data-test-id="track-table-row"
223+
data-testid="track-table-row"
224224
role="row"
225225
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 3em 3em minmax(8em, 1fr) 1fr 6em;"
226226
tabindex="2"
@@ -311,7 +311,7 @@ exports[`Artist view container should display an artist 1`] = `
311311
class="grid_track_table_row"
312312
data-rbd-draggable-context-id="0"
313313
data-rbd-draggable-id="1"
314-
data-test-id="track-table-row"
314+
data-testid="track-table-row"
315315
role="row"
316316
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 3em 3em minmax(8em, 1fr) 1fr 6em;"
317317
tabindex="1"
@@ -402,7 +402,7 @@ exports[`Artist view container should display an artist 1`] = `
402402
class="grid_track_table_row"
403403
data-rbd-draggable-context-id="0"
404404
data-rbd-draggable-id="0"
405-
data-test-id="track-table-row"
405+
data-testid="track-table-row"
406406
role="row"
407407
style="position: absolute; left: 0px; top: 84px; height: 42px; width: 100%; grid-template-columns: 3em 3em minmax(8em, 1fr) 1fr 6em;"
408408
tabindex="0"

‎packages/app/app/containers/DashboardContainer/__snapshots__/DashboardContainer.test.tsx.snap

+4-3
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
585585
>
586586
<div
587587
class="text_header centered"
588+
data-testid="position-header"
588589
>
589590
<i
590591
aria-hidden="true"
@@ -686,7 +687,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
686687
</div>
687688
<div
688689
class="track_table_header_spacer"
689-
data-test-id="track-table-header-spacer"
690+
data-testid="track-table-header-spacer"
690691
/>
691692
</div>
692693
</div>
@@ -708,7 +709,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
708709
class="grid_track_table_row"
709710
data-rbd-draggable-context-id="0"
710711
data-rbd-draggable-id="0"
711-
data-test-id="track-table-row"
712+
data-testid="track-table-row"
712713
role="row"
713714
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 4em 3em 3em minmax(8em, 1fr) 1fr 6em 6em;"
714715
tabindex="0"
@@ -830,7 +831,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
830831
class="grid_track_table_row"
831832
data-rbd-draggable-context-id="0"
832833
data-rbd-draggable-id="1"
833-
data-test-id="track-table-row"
834+
data-testid="track-table-row"
834835
role="row"
835836
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 4em 3em 3em minmax(8em, 1fr) 1fr 6em 6em;"
836837
tabindex="1"

‎packages/app/app/containers/DeezerPlaylistAdapter/__snapshots__/DeezerPlaylistAdapter.test.tsx.snap

+4-3
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
128128
>
129129
<div
130130
class="text_header centered"
131+
data-testid="position-header"
131132
>
132133
<i
133134
aria-hidden="true"
@@ -216,7 +217,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
216217
</div>
217218
<div
218219
class="track_table_header_spacer"
219-
data-test-id="track-table-header-spacer"
220+
data-testid="track-table-header-spacer"
220221
/>
221222
</div>
222223
</div>
@@ -238,7 +239,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
238239
class="grid_track_table_row"
239240
data-rbd-draggable-context-id="1"
240241
data-rbd-draggable-id="0"
241-
data-test-id="track-table-row"
242+
data-testid="track-table-row"
242243
role="row"
243244
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 4em 3em 3em minmax(8em, 1fr) 1fr 6em;"
244245
tabindex="0"
@@ -354,7 +355,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
354355
class="grid_track_table_row"
355356
data-rbd-draggable-context-id="1"
356357
data-rbd-draggable-id="1"
357-
data-test-id="track-table-row"
358+
data-testid="track-table-row"
358359
role="row"
359360
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 4em 3em 3em minmax(8em, 1fr) 1fr 6em;"
360361
tabindex="1"

‎packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11

22
import React from 'react';
33
import { render, waitFor } from '@testing-library/react';
4+
import userEvent from '@testing-library/user-event';
45
import { createMemoryHistory } from 'history';
56
import _, { pick } from 'lodash';
67

8+
import { Track } from '@nuclear/core';
9+
710
import { buildStoreState } from '../../../test/storeBuilders';
811
import { AnyProps, configureMockStore, setupI18Next, TestRouterProvider, TestStoreProvider, uuidRegex } from '../../../test/testUtils';
912
import MainContentContainer from '../MainContentContainer';
1013
import PlayerBarContainer from '../PlayerBarContainer';
11-
import { Track } from '@nuclear/core';
12-
import userEvent from '@testing-library/user-event';
1314

1415
const updateStore = (key: string, value: object) => {
1516
// eslint-disable-next-line @typescript-eslint/no-var-requires

‎packages/app/app/containers/FavoritesContainer/__snapshots__/FavoritesContainer.tracks.test.tsx.snap

+8-6
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
251251
>
252252
<div
253253
class="text_header centered"
254+
data-testid="position-header"
254255
>
255256
<i
256257
aria-hidden="true"
@@ -330,7 +331,7 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
330331
</div>
331332
<div
332333
class="track_table_header_spacer"
333-
data-test-id="track-table-header-spacer"
334+
data-testid="track-table-header-spacer"
334335
/>
335336
</div>
336337
</div>
@@ -352,7 +353,7 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
352353
class="grid_track_table_row"
353354
data-rbd-draggable-context-id="0"
354355
data-rbd-draggable-id="1"
355-
data-test-id="track-table-row"
356+
data-testid="track-table-row"
356357
role="row"
357358
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em minmax(8em, 1fr) 1fr 6em;"
358359
tabindex="1"
@@ -468,7 +469,7 @@ exports[`Favorite tracks view container should display favorite tracks 1`] = `
468469
class="grid_track_table_row"
469470
data-rbd-draggable-context-id="0"
470471
data-rbd-draggable-id="0"
471-
data-test-id="track-table-row"
472+
data-testid="track-table-row"
472473
role="row"
473474
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em minmax(8em, 1fr) 1fr 6em;"
474475
tabindex="0"
@@ -823,6 +824,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
823824
>
824825
<div
825826
class="text_header centered"
827+
data-testid="position-header"
826828
>
827829
<i
828830
aria-hidden="true"
@@ -902,7 +904,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
902904
</div>
903905
<div
904906
class="track_table_header_spacer"
905-
data-test-id="track-table-header-spacer"
907+
data-testid="track-table-header-spacer"
906908
/>
907909
</div>
908910
</div>
@@ -924,7 +926,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
924926
class="grid_track_table_row"
925927
data-rbd-draggable-context-id="2"
926928
data-rbd-draggable-id="1"
927-
data-test-id="track-table-row"
929+
data-testid="track-table-row"
928930
role="row"
929931
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em minmax(8em, 1fr) 1fr 6em;"
930932
tabindex="1"
@@ -1040,7 +1042,7 @@ exports[`Favorite tracks view container should show a popup when a track is clic
10401042
class="grid_track_table_row"
10411043
data-rbd-draggable-context-id="2"
10421044
data-rbd-draggable-id="0"
1043-
data-test-id="track-table-row"
1045+
data-testid="track-table-row"
10441046
role="row"
10451047
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em minmax(8em, 1fr) 1fr 6em;"
10461048
tabindex="0"

‎packages/app/app/containers/LibraryViewContainer/__snapshots__/LibraryViewContainer.test.tsx.snap

+5-4
Original file line numberDiff line numberDiff line change
@@ -848,6 +848,7 @@ exports[`Library view container should display local library in simple list mode
848848
>
849849
<div
850850
class="text_header centered"
851+
data-testid="position-header"
851852
>
852853
<i
853854
aria-hidden="true"
@@ -953,7 +954,7 @@ exports[`Library view container should display local library in simple list mode
953954
</div>
954955
<div
955956
class="track_table_header_spacer"
956-
data-test-id="track-table-header-spacer"
957+
data-testid="track-table-header-spacer"
957958
/>
958959
</div>
959960
</div>
@@ -975,7 +976,7 @@ exports[`Library view container should display local library in simple list mode
975976
class="grid_track_table_row"
976977
data-rbd-draggable-context-id="0"
977978
data-rbd-draggable-id="0"
978-
data-test-id="track-table-row"
979+
data-testid="track-table-row"
979980
role="row"
980981
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 4em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em;"
981982
tabindex="0"
@@ -1088,7 +1089,7 @@ exports[`Library view container should display local library in simple list mode
10881089
class="grid_track_table_row"
10891090
data-rbd-draggable-context-id="0"
10901091
data-rbd-draggable-id="1"
1091-
data-test-id="track-table-row"
1092+
data-testid="track-table-row"
10921093
role="row"
10931094
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 4em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em;"
10941095
tabindex="1"
@@ -1201,7 +1202,7 @@ exports[`Library view container should display local library in simple list mode
12011202
class="grid_track_table_row"
12021203
data-rbd-draggable-context-id="0"
12031204
data-rbd-draggable-id="2"
1204-
data-test-id="track-table-row"
1205+
data-testid="track-table-row"
12051206
role="row"
12061207
style="position: absolute; left: 0px; top: 84px; height: 42px; width: 100%; grid-template-columns: 4em 3em minmax(8em, 1fr) 1fr 1fr 6em 6em;"
12071208
tabindex="2"

‎packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable @typescript-eslint/no-var-requires */
22
/* eslint-disable @typescript-eslint/ban-ts-comment */
3-
import { fireEvent, render, waitFor, within } from '@testing-library/react';
3+
import { fireEvent, prettyDOM, render, waitFor, within } from '@testing-library/react';
44
import React from 'react';
55
import { createMemoryHistory } from 'history';
66
import { store as electronStore } from '@nuclear/core';
@@ -313,6 +313,7 @@ describe('Playlist view container - utils', () => {
313313
};
314314
reorder = onReorder(playlist, updatePlaylist);
315315
});
316+
316317
it('should reorder tracks correctly (1)', () => {
317318
reorder(0, 2);
318319
expect(newPlaylist).toEqual({

‎packages/app/app/containers/PlaylistViewContainer/__snapshots__/PlaylistViewContainer.test.tsx.snap

+4-3
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ exports[`Playlist view container should display a playlist 1`] = `
138138
>
139139
<div
140140
class="text_header centered"
141+
data-testid="position-header"
141142
>
142143
<i
143144
aria-hidden="true"
@@ -226,7 +227,7 @@ exports[`Playlist view container should display a playlist 1`] = `
226227
</div>
227228
<div
228229
class="track_table_header_spacer"
229-
data-test-id="track-table-header-spacer"
230+
data-testid="track-table-header-spacer"
230231
/>
231232
</div>
232233
</div>
@@ -251,7 +252,7 @@ exports[`Playlist view container should display a playlist 1`] = `
251252
data-rbd-drag-handle-draggable-id="0"
252253
data-rbd-draggable-context-id="0"
253254
data-rbd-draggable-id="0"
254-
data-test-id="track-table-row"
255+
data-testid="track-table-row"
255256
draggable="false"
256257
role="button"
257258
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 6em;"
@@ -386,7 +387,7 @@ exports[`Playlist view container should display a playlist 1`] = `
386387
data-rbd-drag-handle-draggable-id="1"
387388
data-rbd-draggable-context-id="0"
388389
data-rbd-draggable-id="1"
389-
data-test-id="track-table-row"
390+
data-testid="track-table-row"
390391
draggable="false"
391392
role="button"
392393
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 3em 4em 3em 3em minmax(8em, 1fr) 1fr 6em;"

‎packages/app/app/containers/SpotifyPlaylistAdapter/__snapshots__/SpotifyPlaylistAdapter.test.tsx.snap

+4-3
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ exports[`Spotfiy playlist adapter should display a Spotify playlist 1`] = `
128128
>
129129
<div
130130
class="text_header centered"
131+
data-testid="position-header"
131132
>
132133
<i
133134
aria-hidden="true"
@@ -229,7 +230,7 @@ exports[`Spotfiy playlist adapter should display a Spotify playlist 1`] = `
229230
</div>
230231
<div
231232
class="track_table_header_spacer"
232-
data-test-id="track-table-header-spacer"
233+
data-testid="track-table-header-spacer"
233234
/>
234235
</div>
235236
</div>
@@ -251,7 +252,7 @@ exports[`Spotfiy playlist adapter should display a Spotify playlist 1`] = `
251252
class="grid_track_table_row"
252253
data-rbd-draggable-context-id="0"
253254
data-rbd-draggable-id="0"
254-
data-test-id="track-table-row"
255+
data-testid="track-table-row"
255256
role="row"
256257
style="position: absolute; left: 0px; top: 0px; height: 42px; width: 100%; grid-template-columns: 4em 3em 3em minmax(8em, 1fr) 1fr 6em 6em;"
257258
tabindex="0"
@@ -373,7 +374,7 @@ exports[`Spotfiy playlist adapter should display a Spotify playlist 1`] = `
373374
class="grid_track_table_row"
374375
data-rbd-draggable-context-id="0"
375376
data-rbd-draggable-id="1"
376-
data-test-id="track-table-row"
377+
data-testid="track-table-row"
377378
role="row"
378379
style="position: absolute; left: 0px; top: 42px; height: 42px; width: 100%; grid-template-columns: 4em 3em 3em minmax(8em, 1fr) 1fr 6em 6em;"
379380
tabindex="1"

‎packages/ui/lib/components/GridTrackTable/GridTrackTableRow.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const GridTrackTableRow = memo(<T extends Track>({ index, style, data }:
3131
{
3232
(draggableProvided, draggableSnapshot) => (
3333
<div
34-
data-test-id='track-table-row'
34+
data-testid='track-table-row'
3535
className={cx(
3636
styles.grid_track_table_row,
3737
{ [styles.is_dragging]: draggableSnapshot.isDragging }

0 commit comments

Comments
 (0)