From fc695f84178c088c712480811bad3925c27e9b3f Mon Sep 17 00:00:00 2001 From: Toni Uhlig Date: Sat, 22 Jul 2023 09:02:12 +0200 Subject: [PATCH] Fix string truncation. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ndpi_main.c: In function ‘ndpi_load_ip_category’: ndpi_main.c:6598:3: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation] 6598 | strncpy(ipbuf, ip_address_and_mask, sizeof(ipbuf)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Toni Uhlig --- src/lib/ndpi_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c index d857c58b5a0..a34571c1d34 100644 --- a/src/lib/ndpi_main.c +++ b/src/lib/ndpi_main.c @@ -6595,7 +6595,7 @@ int ndpi_load_ip_category(struct ndpi_detection_module_struct *ndpi_str, if(!ndpi_str->custom_categories.ipAddresses_shadow) return(-1); - strncpy(ipbuf, ip_address_and_mask, sizeof(ipbuf)); + strncpy(ipbuf, ip_address_and_mask, sizeof(ipbuf) - 1); ipbuf[sizeof(ipbuf) - 1] = '\0'; ptr = strrchr(ipbuf, '/');