From 22cf8b5d8f7d28b78b46ded0af5781892795ffb8 Mon Sep 17 00:00:00 2001 From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> Date: Thu, 6 Apr 2023 09:35:27 +0200 Subject: [PATCH] configure: add an option to enable debug build, i.e `-g` (#1929) Add this new flag to one CI job, to test it Close #1925 --- .github/workflows/build_scheduled.yml | 3 ++- configure.ac | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_scheduled.yml b/.github/workflows/build_scheduled.yml index d3f9726ab01..4f051bdb3ca 100644 --- a/.github/workflows/build_scheduled.yml +++ b/.github/workflows/build_scheduled.yml @@ -1,3 +1,4 @@ +name: Scheduled builds on: workflow_dispatch: schedule: @@ -56,7 +57,7 @@ jobs: sudo apt-get install autoconf automake libtool pkg-config gettext flex bison doxygen - name: Configure nDPI library run: | - ./autogen.sh --with-only-libndpi --enable-option-checking=fatal + ./autogen.sh --with-only-libndpi --enable-option-checking=fatal --enable-debug-build - name: Generate Documentation run: | pip install --upgrade pip diff --git a/configure.ac b/configure.ac index 968da913995..57f83708c17 100644 --- a/configure.ac +++ b/configure.ac @@ -27,6 +27,7 @@ AC_ARG_ENABLE(tls-sigs, AS_HELP_STRING([--enable-tls-sigs], [Enable TLS Client s AC_ARG_ENABLE(npcap, AS_HELP_STRING([--disable-npcap], [msys2 only: Disable linkage against the wpcap/npcap import library in windows/WpdPack/Lib.])) AC_ARG_WITH(nbpf-path, AS_HELP_STRING([--with-nbpf-path], [nBPF library custom path; default: ${PWD}/../PF_RING/userland/nbpf]),[NBPF_HOME=$withval],[NBPF_HOME=${PWD}/../PF_RING/userland/nbpf]) AC_ARG_WITH(lto-and-gold-linker, AS_HELP_STRING([--with-lto-and-gold-linker], [Build with LTO and Gold linker])) +AC_ARG_ENABLE(debug-build, AS_HELP_STRING([--enable-debug-build], [Enable debug build (`-g` flag)]),[enable_debugbuild=$enableval],[enable_debugbuild=no]) AS_IF([test "x$enable_fuzztargets" = "xyes"], [ BUILD_FUZZTARGETS=1 @@ -34,6 +35,10 @@ AS_IF([test "x$enable_fuzztargets" = "xyes"], [ ], [BUILD_FUZZTARGETS=0]) AM_CONDITIONAL([BUILD_FUZZTARGETS], [test "x$enable_fuzztargets" = "xyes"]) +AS_IF([test "x$enable_debugbuild" = "xyes"], [ + NDPI_CFLAGS="${NDPI_CFLAGS} -g" +]) + AS_IF([test "${with_sanitizer+set}" = set -a "${with_thread_sanitizer+set}" = set],[ AC_MSG_ERROR([Configure options `--with-sanitizer' and `--with_thread_sanitizer' can not used at the same time.]) ])