Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mybinder.org build broken because of setup.py and pyproject.toml presence #348

Closed
betatim opened this issue Apr 27, 2019 · 1 comment · Fixed by #349
Closed

mybinder.org build broken because of setup.py and pyproject.toml presence #348

betatim opened this issue Apr 27, 2019 · 1 comment · Fixed by #349

Comments

@betatim
Copy link
Member

betatim commented Apr 27, 2019

The build on mybinder.org (via repo2docker) is broken :-(

The error I see is:

ERROR: Error installing 'file:///home/jovyan (from -r binder/requirements.txt (line 1))': editable mode is not supported for pyproject.toml-style projects. pip is processing this project as pyproject.toml-style because it has a pyproject.toml file. Since the project has a setup.py and the pyproject.toml has no "build-backend" key for the "build_system" value, you may pass --no-use-pep517 to opt out of pyproject.toml-style processing. See PEP 517 for details on pyproject.toml-style projects.

I think this broke when we upgraded repo2docker to use a modern version of pip (v19.0.3 or some such), before it was v18.

Maybe now there is a 1.0.0 release we can install from PyPI instead of from the repo? Or figure out what additional arguments need passing to pip to sort out the competition between setup.py and pyproject.toml.

@MSeal
Copy link
Member

MSeal commented Apr 27, 2019

Yea I just noticed this today and was looking at we might fix it. I think the main issue is our pyproject.toml needs to be updated. I'm gonna try it out and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants