-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsqd: client error logged even when cleanly closed #521
Comments
Can you paste code? You can turn P.S. This issue probably belongs on the |
hi, i found this error reported by func (*Reader) ReadSlice
I'm not familiar with Go:( |
Right, this is most likely an issue with Yes, I meant |
in fact , i guess it's not about nsq and nsqphp, maybe it's about network.This problem happening on when i move nsqd to new Server Room. |
hi, i used tcpdump to dump some tcp package to local, so can you find anything? |
So you might be running into the same issue I did. Are you using nsqphp for publishing only? If so, take a look at the changes here: davegardnerisme/nsqphp#33 If you're only publishing, nsqphp doesn't attempt to read heartbeats and that gets its reading of the connection in an odd state. If this is what's causing your issue, that PR might solve it for you. |
@stephensearles , i merge your pull request and it's unhelpful:( |
FWIW I get this consistently via go-nsq, latest of both packages, just using defaults. I was looking into what I thought was my own bug with not stopping publishers properly but seems like it's easy to repro: p, _ := nsq.NewProducer(":4150", nsq.NewConfig())
for i := 0; i < 10; i++ {
p.Publish("something", []byte("foo"))
}
p.Stop() |
yea, that's also a I'm gonna close this as I think they're client library issues... I'm going to open one for |
I’m trying out the go-nsq and I see that with consumer the clean-close (CLS is sent) is happening, but still the "failed to read command - EOF" is printed. Is it still a client library issue or nsqd? My logs: from consumer
From nsqd --verbose:
|
Hmmm, ok, I suppose |
Hi @mreiferson Just to add, the go-nsq after it sends FINishing as well, I see the client failed to read command - EOF.
|
@jothirams I'm not sure I follow what situation you're describing, can you provide a reproducible test case, code, or commands I can run? |
@mreiferson The last comment that after FINishing as well, the failed to read command is being displayed is incorrect. I was also using json-to-nsq and it was the problem that the go-nsq However, the client when it still does a |
fixed in #560 |
+1 I am following the instruction of this blog (it is very easy to reproduce): http://tleyden.github.io/blog/2014/11/12/an-example-of-using-nsq-from-go/ I get the same error.
nsqd v0.3.5 (built w/go1.4.2) |
@casertap the change in #560 (included in v0.3.5) only omitted that error when the client initiated a clean close (by sending a |
Thanks @jehiah. |
@casertap I'm not quite sure what your question is beyond the |
Of course. thanks |
Hi everyone. Thanks |
@maderaka can you provide information on what version you are running and the exact log output you are seeing? |
@jehiah That's already fixed. |
@casertap I followed the same example from the same link as you and I get the same error as well. were you able to figure out how the code should look like in that example? If so, can you please forward it? |
nsqd always print log as follow on our production environment:
my environment like this:
and my nsq client used nsqphp
so, Any idea?
The text was updated successfully, but these errors were encountered: