sn/policer: Do not inline sync.RWMutex

This resulted in inheritance of `sync.RWMutex` interface that was not
used and was not usable at all.

Signed-off-by: Leonard Lyubich <[email protected]>

Author: cthulhu-rider

pkg/services/policer/check.go

@@ -185,9 +185,9 @@ type processPlacementContext struct {
 }
 
 func (p *Policer) processNodes(ctx context.Context, plc *processPlacementContext, nodes []netmap.NodeInfo, shortage uint32) {
-	p.cfg.RLock()
+	p.cfg.mtx.RLock()
 	headTimeout := p.headTimeout
-	p.cfg.RUnlock()
+	p.cfg.mtx.RUnlock()
 
 	// Number of copies that are stored on maintenance nodes.
 	var uncheckedCopies int

pkg/services/policer/policer.go

@@ -99,7 +99,7 @@ type Network interface {
 }
 
 type cfg struct {
-	sync.RWMutex
+	mtx sync.RWMutex
 	// available for runtime reconfiguration
 	headTimeout time.Duration
 	repCooldown time.Duration

pkg/services/policer/process.go

@@ -21,10 +21,10 @@ func (p *Policer) Run(ctx context.Context) {
 }
 
 func (p *Policer) shardPolicyWorker(ctx context.Context) {
-	p.cfg.RLock()
+	p.cfg.mtx.RLock()
 	repCooldown := p.repCooldown
 	batchSize := p.batchSize
-	p.cfg.RUnlock()
+	p.cfg.mtx.RUnlock()
 
 	var (
 		addrs  []objectcore.AddressWithType
@@ -80,17 +80,17 @@ func (p *Policer) shardPolicyWorker(ctx context.Context) {
 		case <-ctx.Done():
 			return
 		case <-t.C:
-			p.cfg.RLock()
+			p.cfg.mtx.RLock()
 			t.Reset(p.repCooldown)
-			p.cfg.RUnlock()
+			p.cfg.mtx.RUnlock()
 		}
 	}
 }
 
 func (p *Policer) poolCapacityWorker(ctx context.Context) {
-	p.cfg.RLock()
+	p.cfg.mtx.RLock()
 	maxCapacity := p.maxCapacity
-	p.cfg.RUnlock()
+	p.cfg.mtx.RUnlock()
 
 	ticker := time.NewTicker(p.rebalanceFreq)
 	for {

pkg/services/policer/reload.go

@@ -13,8 +13,8 @@ func (p *Policer) Reload(opts ...Option) {
 		o(cfg)
 	}
 
-	p.cfg.Lock()
-	defer p.cfg.Unlock()
+	p.cfg.mtx.Lock()
+	defer p.cfg.mtx.Unlock()
 
 	p.headTimeout = cfg.headTimeout
 	p.repCooldown = cfg.repCooldown