Support container deletion lock #558
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 63.37% 63.42% +0.05%
==========================================
Files 29 29
Lines 3279 3303 +24
==========================================
+ Hits 2078 2095 +17
- Misses 1195 1202 +7
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
container-lock
branch
from
c35b324 to
8be2e26
Compare
cthulhu-rider
force-pushed
the
container-lock
branch
from
8be2e26 to
36ea58a
Compare
cthulhu-rider
force-pushed
the
container-lock
branch
2 times, most recently
from
98910b0 to
332b5e1
Compare
cthulhu-rider
requested review from
carpawell and
roman-khimov
as code owners
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Dec 3, 2025
This auto-makes IR to deploy/update Container contract with supported locks nspcc-dev/neofs-contract#558. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Dec 3, 2025
Catch 'container is locked' exception added in nspcc-dev/neofs-contract#558 and respond with `CONTAINER_LOCKED` API status on it. Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov
reviewed
Dec 5, 2025
cthulhu-rider
force-pushed
the
container-lock
branch
from
332b5e1 to
3384793
Compare
Attribute was introduced in nspcc-dev/neofs-api#357. It is now validated on creation, checked on deletion and can be set/reset in existing container. Closes #497. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
container-lock
branch
from
3384793 to
a62baea
Compare
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Dec 5, 2025
This auto-makes IR to deploy/update Container contract with supported locks nspcc-dev/neofs-contract#558. This also makes IR to accept containers with lock attribute. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Dec 5, 2025
Catch 'container is locked' exception added in nspcc-dev/neofs-contract#558 and respond with `CONTAINER_LOCKED` API status on it. Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov
reviewed
Dec 5, 2025
contracts/container/contract.go
Outdated
|
|
||
| switch name { | ||
| case corsAttributeName: | ||
| case corsAttributeName, lockAttributeName: |
Member
There was a problem hiding this comment.
This attribute can't be removed/changed that easy. Treat it like a LOCK object, the lock can be extended, but not shortened or deleted, that's the purpose of it.
Contributor
Author
There was a problem hiding this comment.
make it disposable?
Member
There was a problem hiding this comment.
After it expires it can be deleted, but not sooner than that.
cthulhu-rider
commented
Dec 5, 2025
| for i := range cnr.Attributes { | ||
| switch cnr.Attributes[i].Key { | ||
| case lockAttributeName: | ||
| if std.Atoi10(cnr.Attributes[i].Value) <= 0 { |
Contributor
Author
There was a problem hiding this comment.
also thinking of check against current time
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
container-lock
branch
from
566b49f to
e01c939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also wanna w8 4 #555 and provide option to set lock attribute the same way