Skip to content

Create python package and publish to PyPI #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lisakaser opened this issue Sep 17, 2024 · 8 comments
Closed

Create python package and publish to PyPI #62

lisakaser opened this issue Sep 17, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@lisakaser
Copy link

No description provided.

@lisakaser lisakaser added this to the DPT Minimum Viable Product milestone Sep 17, 2024
@lisakaser lisakaser added the enhancement New feature or request label Oct 7, 2024
@eigenbeam
Copy link
Contributor

As an operator, when I want to install metgenc, I can use pip to install it from PyPI.

As a developer, when I want to make a release of metgenc, I can run a command that will trigger a build of the package, and, if successful, publish the new version to PyPI.

As an operator or developer or project manager, when I want to see what was in a new release, I can view the project's CHANGELOG in GitHub.

@eigenbeam eigenbeam assigned afitzgerrell and unassigned eigenbeam Dec 5, 2024
@afitzgerrell
Copy link
Contributor

I'm not sure how best to test this since I already have metgenc installed and I don't know enough to feel confident I can avoid clobbering/wrecking something and getting myself into a pickle. If you have suggestions for how to be brave and go for it, I'll listen and follow.

I took a look at the PyPi site and easily found nsidc-metgenc by searching for "metgenc". There's currently a discrepancy between the GitHub README contents and those on the PyPi nsidc-metgenc page. Is it safe to assume synchronizing those are just on pause during the flurry of development work, and they'll ultimately be unified to match?

@eigenbeam
Copy link
Contributor

eigenbeam commented Dec 23, 2024

Since your previous install was via Poetry, this should work:

  1. Fire up a new terminal window (and don't run 'poetry shell')
  2. Run pip install --user nsidc-metgenc.
  3. This should result in metgenc getting installed from PyPI in your local python user package directory, and when you run metgenc it will be this one, not the Poetry-installed version from GitHub

I'm going to update the README to reflect the --user option on the pip command.

@afitzgerrell
Copy link
Contributor

Thanks Kevin! I was able to get it installed via...long story short: a new virtual environment. Anyhoo, I did indeed install it from pip ✅, and it's functional (I tested validate and process -d)

  • sidenote: in the pip-installed version of metgenc, the many spaces are still present in the dry run's note Note: The dry-run option was included, so no files will be staged and no CNM messages published.

I've verified that the change log / PyPi versions jive ✅

@eigenbeam
Copy link
Contributor

Yeah, the fix for the extra spaces is not yet in a released version, that is, a version that is installable via PyPI.

@eigenbeam
Copy link
Contributor

Oh, same with the README change. It is not in a release.

@afitzgerrell
Copy link
Contributor

All duly noted. I'll consider this testing complete, because for the point of the issue, it is!!

@lisakaser
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants