Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pv/bg-bm] Handle non-existing Makefile / manifest in plugin archive #8

Open
nrybowski opened this issue Dec 10, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@nrybowski
Copy link
Owner

binding_generator_1  | make: Entering directory '/tmp/tmpgxvek67y/zombi'
binding_generator_1  | make: Leaving directory '/tmp/tmpgxvek67y/zombi'
binding_generator_1  | make: *** No targets specified and no makefile found.  Stop.
binding_generator_1  | [2021-12-10 23:21:48,158] ERROR in app: Exception on /binding/zombi [POST]
binding_generator_1  | Traceback (most recent call last):
binding_generator_1  |   File "/usr/local/lib/python3.9/dist-packages/flask/app.py", line 2447, in wsgi_app
binding_generator_1  |     response = self.full_dispatch_request()
binding_generator_1  |   File "/usr/local/lib/python3.9/dist-packages/flask/app.py", line 1952, in full_dispatch_request
binding_generator_1  |     rv = self.handle_user_exception(e)
binding_generator_1  |   File "/usr/local/lib/python3.9/dist-packages/flask/app.py", line 1821, in handle_user_exception
binding_generator_1  |     reraise(exc_type, exc_value, tb)
binding_generator_1  |   File "/usr/local/lib/python3.9/dist-packages/flask/_compat.py", line 39, in reraise
binding_generator_1  |     raise value
binding_generator_1  |   File "/usr/local/lib/python3.9/dist-packages/flask/app.py", line 1950, in full_dispatch_request
binding_generator_1  |     rv = self.dispatch_request()
binding_generator_1  |   File "/usr/local/lib/python3.9/dist-packages/flask/app.py", line 1936, in dispatch_request
binding_generator_1  |     return self.view_functions[rule.endpoint](**req.view_args)
binding_generator_1  |   File "/pv/binding_generator/api.py", line 15, in get_binding
binding_generator_1  |     return format(generate_binding(request.data, escape(plugin_name)))
binding_generator_1  |   File "/pv/binding_generator/__init__.py", line 37, in generate_binding
binding_generator_1  |     plugins = parse_manifest(manifest_path)
binding_generator_1  |   File "/pv/binding_generator/__init__.py", line 14, in parse_manifest
binding_generator_1  |     with open(manifest_path, 'r') as fd:
binding_generator_1  | FileNotFoundError: [Errno 2] No such file or directory: Markup('/tmp/tmpgxvek67y/zombi/manifest.json')
logger_1             | [2021-12-10 23:21:48] [ERROR] <pv.binding_manager.api> Exception on /binding/zombi [POST]
binding_manager_1    | [2021-12-10 23:21:48,163] ERROR in app: Exception on /binding/zombi [POST]
binding_manager_1    | Traceback (most recent call last):
binding_manager_1    |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 2447, in wsgi_app
binding_manager_1    |     response = self.full_dispatch_request()
binding_manager_1    |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 1953, in full_dispatch_request
binding_manager_1    |     return self.finalize_request(rv)
binding_manager_1    |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 1968, in finalize_request
binding_manager_1    |     response = self.make_response(rv)
binding_manager_1    |   File "/usr/lib/python3.8/site-packages/flask/app.py", line 2097, in make_response
binding_manager_1    |     raise TypeError(
binding_manager_1    | TypeError: The view function did not return a valid response. The function either returned None or ended without a return statement.
@nrybowski nrybowski added the bug Something isn't working label Dec 10, 2021
@nrybowski nrybowski changed the title pv:bg/bm: Handle non-existing Makefile / manifest in plugin archive [pv/bg-bm] Handle non-existing Makefile / manifest in plugin archive Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant