fix(js): add input on .d.ts files within dependency projects#34968
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 124e7ed
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ The fix from Nx Cloud was applied
We updated 91 inline snapshots in plugin.spec.ts to include the newly added { "dependencies": true, "fileset": "**/*.d.ts" } input entry, which was introduced by the PR's change to getInputs() in plugin.ts. Without these snapshot updates, the js:test task fails with 87 mismatches because the received output now contains this additional entry that the existing snapshots did not anticipate.
Warning
- ❌ We could not verify this fix.
- The suggested diff is too large to display here, but you can view it on Nx Cloud ↗
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
➡️ This fix was applied by Craigory Coppola
🎓 Learn more about Self-Healing CI on nx.dev
Co-authored-by: AgentEnder <AgentEnder@users.noreply.github.com>
This pull request makes a targeted improvement to how TypeScript dependency tracking is handled in the build system. Specifically, it ensures that all `*.d.ts` files from dependent projects are included as inputs, improving type safety and correctness in incremental builds. Dependency tracking improvements: * Updated the `getInputs` function in `plugin.ts` to add all `*.d.ts` files from dependencies as tracked inputs, ensuring that changes to type definition files in dependent projects are properly detected and trigger rebuilds. --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: AgentEnder <AgentEnder@users.noreply.github.com> (cherry picked from commit f81ad07)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
2 participants
This pull request makes a targeted improvement to how TypeScript dependency tracking is handled in the build system. Specifically, it ensures that all
*.d.tsfiles from dependent projects are included as inputs, improving type safety and correctness in incremental builds.Dependency tracking improvements:
getInputsfunction inplugin.tsto add all*.d.tsfiles from dependencies as tracked inputs, ensuring that changes to type definition files in dependent projects are properly detected and trigger rebuilds.