fix(core): prevent TUI crash when task output arrives after completion#34785
Merged
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 618a997
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
Mar 21, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 26, 2026
#34785) ## Current Behavior `nx run-many` with TUI enabled crashes with `TypeError: Cannot read properties of undefined (reading 'push')` in `tui-summary-life-cycle.ts` when `appendTaskOutput` is called for a task whose output entry was already cleaned up by `endTasks`. ## Expected Behavior Late-arriving task output after `endTasks` has finalized the task is silently discarded instead of crashing. The output is redundant since it was already captured when the task completed. ## Related Issue(s) Fixes #34677 (cherry picked from commit 5e5184e)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx run-manywith TUI enabled crashes withTypeError: Cannot read properties of undefined (reading 'push')intui-summary-life-cycle.tswhenappendTaskOutputis called for a task whose output entry was already cleaned up byendTasks.Expected Behavior
Late-arriving task output after
endTaskshas finalized the task is silently discarded instead of crashing. The output is redundant since it was already captured when the task completed.Related Issue(s)
Fixes #34677