-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(core): add env var to disable fetching migration metadata from registry #32850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add env var to disable fetching migration metadata from registry #32850
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 492c374
☁️ Nx Cloud last updated this comment at |
astro-docs/src/content/docs/reference/environment-variables.mdoc
Outdated
Show resolved
Hide resolved
77ddeb9 to
492c374
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The failure is classified as 'environment_state' because it is caused by an environmental issue rather than the code changes in this pull request.
Analysis of the failure:
The test failure occurs with the error message:
Command failed: npx playwright install --with-deps
E: Could not get lock /var/lib/apt/lists/lock. It is held by process 24753 (apt-get)
E: Unable to lock directory /var/lib/apt/lists/
This is a clear environmental failure where:
- The system package manager (apt) is already running or locked by another process
- This prevents Playwright from installing system dependencies with
--with-deps - The error is related to Linux system package management, not the code changes
Why this is not related to the PR changes:
The PR changes involve:
- Adding a new environment variable
NX_MIGRATE_SKIP_REGISTRY_FETCH - Updating documentation to describe this variable
- Adding logic in
migrate.tsto check this environment variable and skip registry fetching
These changes have no relationship to:
- Playwright browser installation
- System package management
- APT lock conflicts
- E2E test environment setup
Evidence this is environmental:
- The error occurs during Playwright browser installation, which is an environmental setup step
- APT lock conflicts are classic environmental issues in CI systems
- The same test appears to have passed in other parts of the test suite, indicating the issue is intermittent and environmental
- No similar failures are present in the
<similar_task_failures>section, suggesting this is a transient environmental issue
The failure is unrelated to the pull request's code changes and represents a temporary system-level resource contention issue.
A code change would likely not resolve this issue, so no action was taken.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Add a new
NX_MIGRATE_SKIP_REGISTRY_FETCHenvironment variable to opt out of fetching package versions and migrations metadata from the registry and instead, use package installation to get the information.