Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove readProjectsConfigurations from workspaces #18329

Merged
merged 2 commits into from
Aug 15, 2023
Merged

chore(core): remove readProjectsConfigurations from workspaces #18329

merged 2 commits into from
Aug 15, 2023

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jul 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:20pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 26, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0598c44. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from 3918507 to 57c03fa Compare July 26, 2023 18:21
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from 57c03fa to e29db88 Compare July 27, 2023 15:22
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from e29db88 to 8850f0d Compare July 27, 2023 17:57
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from 8850f0d to c85a37c Compare July 27, 2023 19:14
@xiongemi xiongemi marked this pull request as ready for review August 2, 2023 18:12
FrozenPandaz
FrozenPandaz requested changes Aug 8, 2023
View reviewed changes
e2e/utils/command-utils.ts Outdated Show resolved Hide resolved
packages/nx/src/config/configuration.ts Outdated Show resolved Hide resolved
packages/nx/src/config/workspaces.ts Outdated Show resolved Hide resolved
packages/nx/src/config/workspaces.ts Outdated Show resolved Hide resolved
packages/nx/src/daemon/server/project-graph-incremental-recomputation.ts Outdated Show resolved Hide resolved
packages/nx/src/devkit-exports.ts Outdated Show resolved Hide resolved
packages/nx/src/config/workspaces.ts Outdated Show resolved Hide resolved
packages/nx/src/project-graph/file-utils.ts Outdated Show resolved Hide resolved
packages/nx/src/project-graph/utils/retrieve-workspace-files.ts Outdated Show resolved Hide resolved
packages/nx/src/project-graph/utils/retrieve-workspace-files.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from c85a37c to e2cf6b9 Compare August 9, 2023 18:22
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from e2cf6b9 to c1a78ec Compare August 9, 2023 20:38
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from feea67a to cf1ff45 Compare August 10, 2023 19:05
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from cf1ff45 to db41a16 Compare August 10, 2023 22:24
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from db41a16 to e70809b Compare August 11, 2023 02:41
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from e70809b to 64fa388 Compare August 11, 2023 03:03
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from 64fa388 to 6e2a1df Compare August 11, 2023 05:50
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from 6e2a1df to 98deb4f Compare August 11, 2023 14:21
FrozenPandaz
FrozenPandaz requested changes Aug 11, 2023
View reviewed changes
docs/generated/devkit/Workspaces.md Outdated Show resolved Hide resolved
packages/nx/src/config/workspaces.ts Outdated Show resolved Hide resolved
packages/nx/src/config/workspaces.ts Show resolved Hide resolved
packages/nx/src/config/workspaces.ts Outdated Show resolved Hide resolved
packages/nx/src/project-graph/build-project-graph.ts Show resolved Hide resolved
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from 98deb4f to 6e26342 Compare August 14, 2023 19:30
@FrozenPandaz FrozenPandaz force-pushed the chore/workspaces-remove-readProjectsConfigurations branch 2 times, most recently from f17bc44 to fd70114 Compare August 14, 2023 20:41
@xiongemi xiongemi force-pushed the chore/workspaces-remove-readProjectsConfigurations branch from fd70114 to 0598c44 Compare August 15, 2023 15:14
@FrozenPandaz FrozenPandaz merged commit 40d66ec into nrwl:master Aug 15, 2023
3 checks passed
@pvds pvds mentioned this pull request Aug 16, 2023
Closed
4 tasks
FrozenPandaz pushed a commit that referenced this pull request Aug 16, 2023
@xiongemi @FrozenPandaz
chore(core): remove readProjectsConfigurations from workspaces (#18329)
14d48c6 
Co-authored-by: FrozenPandaz <[email protected]>
(cherry picked from commit 40d66ec)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
@xiongemi xiongemi deleted the chore/workspaces-remove-readProjectsConfigurations branch April 24, 2024 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meeroslav meeroslav meeroslav left review comments

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@mandarini mandarini mandarini approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo was automatically assigned from nrwl/nx-angular-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongemi @meeroslav @mandarini @FrozenPandaz @barbados-clemens