Skip to content

Commit d01bcb4

Browse files
authored
chore(repo): fix quotes in e2e matrix workflow (#33138)
Fixes wrong single quotes in the E2E matrix workflow file that were preventing variable expansion in bash.
1 parent 3f7e152 commit d01bcb4

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

.github/workflows/e2e-matrix.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464

6565
- name: Get pnpm store directory
6666
id: pnpm-cache
67-
run: echo 'path=$(pnpm store path)' >> $GITHUB_OUTPUT
67+
run: echo "path=$(pnpm store path)" >> $GITHUB_OUTPUT
6868

6969
- name: Cache pnpm store
7070
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # v4.2.4
@@ -87,7 +87,7 @@ jobs:
8787
- name: Homebrew cache directory path
8888
if: ${{ matrix.os == 'macos-latest' }}
8989
id: homebrew-cache-dir-path
90-
run: echo 'dir=$(brew --cache)' >> $GITHUB_OUTPUT
90+
run: echo "dir=$(brew --cache)" >> $GITHUB_OUTPUT
9191

9292
- name: Cache Homebrew
9393
if: ${{ matrix.os == 'macos-latest' }}
@@ -127,7 +127,7 @@ jobs:
127127

128128
- name: Process matrix data
129129
id: process-json
130-
run: echo 'MATRIX=$(npx tsx .github/workflows/nightly/process-matrix.ts | jq -c .)' >> $GITHUB_OUTPUT
130+
run: echo "MATRIX=$(npx tsx .github/workflows/nightly/process-matrix.ts | jq -c .)" >> $GITHUB_OUTPUT
131131

132132
e2e:
133133
if: ${{ github.repository_owner == 'nrwl' }}
@@ -169,12 +169,12 @@ jobs:
169169
if: ${{ matrix.os != 'windows-latest' }}
170170
run: |
171171
curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh -s -- -y
172-
source '$HOME/.cargo/env'
172+
source "$HOME/.cargo/env"
173173
rustup toolchain install 1.70.0
174174
175175
- name: Load Cargo Env
176176
if: ${{ matrix.os != 'windows-latest' }}
177-
run: echo 'PATH=$HOME/.cargo/bin:$PATH' >> $GITHUB_ENV
177+
run: echo "PATH=$HOME/.cargo/bin:$PATH" >> $GITHUB_ENV
178178

179179
- name: Setup .NET 9
180180
uses: actions/setup-dotnet@d4c94342e560b34958eacfc5d055d21461ed1c5d # v5.0.0
@@ -200,14 +200,14 @@ jobs:
200200
sudo rm -rf /usr/share/dotnet
201201
sudo rm -rf /opt/ghc
202202
sudo rm -rf '/usr/local/share/boost'
203-
sudo rm -rf '$AGENT_TOOLSDIRECTORY'
203+
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
204204
sudo apt-get install lsof
205205
echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
206206
207207
- name: Homebrew cache directory path
208208
if: ${{ matrix.os == 'macos-latest' }}
209209
id: homebrew-cache-dir-path
210-
run: echo 'dir=$(brew --cache)' >> $GITHUB_OUTPUT
210+
run: echo "dir=$(brew --cache)" >> $GITHUB_OUTPUT
211211

212212
- name: Cache Homebrew
213213
if: ${{ matrix.os == 'macos-latest' }}
@@ -334,7 +334,7 @@ jobs:
334334
id: before-e2e
335335
shell: bash
336336
run: |
337-
echo 'timestamp=$(date +%s)' >> $GITHUB_OUTPUT
337+
echo "timestamp=$(date +%s)" >> $GITHUB_OUTPUT
338338
339339
- name: Run e2e tests with pnpm (Linux/Windows)
340340
id: e2e-run-pnpm
@@ -397,8 +397,8 @@ jobs:
397397
398398
matrix=$((
399399
echo '${{ toJSON(matrix) }}'
400-
) | jq --argjson delta $delta -c '. + { 'status': '''$outcome''', 'duration': $delta }')
401-
echo '$matrix' > 'outputs/matrix.json'
400+
) | jq --argjson delta $delta -c '. + { "status": "'"$outcome"'", "duration": $delta }')
401+
echo "$matrix" > 'outputs/matrix.json'
402402
403403
- name: Upload matrix config
404404
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
@@ -446,7 +446,7 @@ jobs:
446446
id: combine-json
447447
run: |
448448
combined=$(jq -sc . outputs/*/matrix.json)
449-
echo 'combined=$combined' >> $GITHUB_OUTPUT
449+
echo "combined=$combined" >> $GITHUB_OUTPUT
450450
451451
- name: Process results with TypeScript script
452452
id: process-json

0 commit comments

Comments
 (0)