feat(core): add id, start and end time to lifecycle hooks (#32583)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Pre and post hooks lack corellation Id which might make it difficult to
culculate stats for task using pre and post hooks.
Additionally, post hook does not expose the duration or time span for
the task. Using pre/post hook might not be precise enough.

## Expected Behavior
Hooks expose the unique taskId so we can corellate pre hook of a task to
the post hook of the same task. Post hook should expose start and end
time of the task run.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Resolves discussion
[31076](#31076)

Author: meeroslav

packages/nx/src/command-line/release/publish.ts

@@ -7,6 +7,7 @@ import {
   ProjectGraph,
   ProjectGraphProjectNode,
 } from '../../config/project-graph';
+import { hashArray } from '../../native';
 import { createProjectFileMapUsingProjectGraph } from '../../project-graph/file-map-utils';
 import {
   runPostTasksExecution,
@@ -272,11 +273,14 @@ async function runPublishOnProjects(
       ].join('\n')}\n`
     );
   }
+  const id = hashArray([...process.argv, Date.now().toString()]);
   await runPreTasksExecution({
+    id,
     workspaceRoot,
     nxJsonConfiguration: nxJson,
     argv: process.argv,
   });
+  const startTime = Date.now();
 
   /**
    * Run the relevant nx-release-publish executor on each of the selected projects.
@@ -299,6 +303,7 @@ async function runPublishOnProjects(
     {},
     extraOptions
   );
+  const endTime = Date.now();
 
   const publishProjectsResult: PublishProjectsResult = {};
   for (const taskData of Object.values(taskResults)) {
@@ -307,10 +312,13 @@ async function runPublishOnProjects(
     };
   }
   await runPostTasksExecution({
+    id,
     taskResults,
     workspaceRoot,
     nxJsonConfiguration: nxJson,
     argv: process.argv,
+    startTime,
+    endTime,
   });
 
   return publishProjectsResult;

packages/nx/src/project-graph/plugins/loaded-nx-plugin.ts

@@ -1,5 +1,5 @@
 import type { ProjectGraph } from '../../config/project-graph';
-import { readNxJson, type PluginConfiguration } from '../../config/nx-json';
+import { type PluginConfiguration } from '../../config/nx-json';
 import {
   AggregateCreateNodesError,
   isAggregateCreateNodesError,
@@ -15,7 +15,6 @@ import type {
   PreTasksExecutionContext,
   ProjectsMetadata,
 } from './public-api';
-import { createNodesFromFiles } from './utils';
 import { isIsolationEnabled } from './isolation/enabled';
 import { isDaemonEnabled } from '../../daemon/client/client';
 

packages/nx/src/project-graph/plugins/public-api.ts

@@ -190,15 +190,19 @@ export type NxPluginV2<TOptions = unknown> = {
 };
 
 export type PreTasksExecutionContext = {
+  readonly id: string;
   readonly workspaceRoot: string;
   readonly nxJsonConfiguration: NxJsonConfiguration;
   readonly argv: string[];
 };
 export type PostTasksExecutionContext = {
+  readonly id: string;
   readonly workspaceRoot: string;
   readonly nxJsonConfiguration: NxJsonConfiguration;
   readonly taskResults: TaskResults;
   readonly argv: string[];
+  readonly startTime: number;
+  readonly endTime: number;
 };
 
 export type PreTasksExecution<TOptions = unknown> = (

packages/nx/src/tasks-runner/life-cycle.ts

@@ -22,14 +22,6 @@ export interface TaskMetadata {
   groupId: number;
 }
 
-interface RustRunningTask extends RunningTask {
-  getResults(): Promise<{ code: number; terminalOutput: string }>;
-
-  onExit(cb: (code: number, terminalOutput: string) => void): void;
-
-  kill(signal?: NodeJS.Signals): Promise<void> | void;
-}
-
 export interface LifeCycle {
   startCommand?(parallel?: number): void | Promise<void>;
 

packages/nx/src/tasks-runner/run-command.ts

@@ -17,7 +17,7 @@ import {
   getTaskDetails,
   hashTasksThatDoNotDependOnOutputsOfOtherTasks,
 } from '../hasher/hash-task';
-import { logDebug, RunMode } from '../native';
+import { hashArray, logDebug, RunMode } from '../native';
 import {
   runPostTasksExecution,
   runPreTasksExecution,
@@ -133,8 +133,6 @@ async function getTerminalOutputLifeCycle(
     const isRunOne = initiatingProject != null;
 
     const pinnedTasks: string[] = [];
-    const taskText = tasks.length === 1 ? 'task' : 'tasks';
-    const projectText = projectNames.length === 1 ? 'project' : 'projects';
     let titleText = '';
 
     if (isRunOne) {
@@ -439,12 +437,15 @@ export async function runCommand(
   const status = await handleErrors(
     process.env.NX_VERBOSE_LOGGING === 'true',
     async () => {
+      const id = hashArray([...process.argv, Date.now().toString()]);
       await runPreTasksExecution({
+        id,
         workspaceRoot,
         nxJsonConfiguration: nxJson,
         argv: process.argv,
       });
 
+      const startTime = Date.now();
       const { taskResults, completed } = await runCommandForTasks(
         projectsToRun,
         currentProjectGraph,
@@ -461,6 +462,7 @@ export async function runCommand(
         extraTargetDependencies,
         extraOptions
       );
+      const endTime = Date.now();
 
       const exitCode = !completed
         ? signalToCode('SIGINT')
@@ -472,10 +474,13 @@ export async function runCommand(
         : 0;
 
       await runPostTasksExecution({
+        id,
         taskResults,
         workspaceRoot,
         nxJsonConfiguration: nxJson,
         argv: process.argv,
+        startTime,
+        endTime,
       });
 
       return exitCode;